the bug of filter

[my3188]

• vuex-persistedstate version:2.7.0
• node version:12.14.0
• npm (or yarn) version:6.13.4

Relevant code or config

export default new Vuex.Store({
  state,
  getters,
  mutations,
  actions,
  modules,
  plugins: [
    createPersistedState({
      storage: window.sessionStorage,
      filter: mutation => {
        let rs = mutation.type != "UPDATE_NAME";
        return rs;
      },
      
    })
  ],
});

What you did:
I want all state to be persistent, except for state.name, The Mutations of state.name is “UPDATE_NAME”.
What happened:
I find state.name is persistent

Reproduction sandbox:

Problem description:

Suggested solution:

[my3188]

reducer 和 filter都存在bug,我已经在开发中测试证明存在bug
paths是可以使用的，但是它只支持类似白名单的功能，不支持类似黑名单的功能，所以使用起来在某些场景下会麻烦

[robinvdvleuten]

I am missing a codesandbox here so I can reproduce it out myself. Could you try to filter out the state.name through the paths option?

[robinvdvleuten]

Or is that what you've tried to say in your comment? I cannot read any Asian characters.

[my3188]

Or is that what you've tried to say in your comment? I cannot read any Asian characters.

There are bugs in both reducer and filter. I have tested and proved that there are bugs in development.Paths can be used correctly, but it only supports functions similar to white list, and does not support functions similar to black list, so it will be troublesome in some scenarios.
Like the above example, I may have 100 states, I hope 99 states are persistent, only one is not persistent, and using paths is very inconvenient

[my3188]

I am missing a codesandbox here so I can reproduce it out myself. Could you try to filter out the state.name through the paths option?

paths is ok.but paths is Inconvenient in my scene.

[moltar]

I'm seeing this bug too. filter has no effect.

[TheFrogDaddy]

I too have this same issue, filter fires but has no effect.

[mozart77]

Same story

[iqbaladinur]

same here, i have tried reduce and filter. no one work.

[robinvdvleuten]

Can someone who has issues with this create a reproducible sandbox please?

[myzkyy]

I noticed that returning false in filter function prevent from running persist at that time, but the state is eventually persisted when the other mutation is called.

Sample code:
https://codesandbox.io/s/vuex-persistedstate-filter-sample-iwt6t

[robinchow]

Looking at the implementation a bit more - filter is working as intended. It only filters mutations that triggers saving the vuex state - it's not intended to define which parts of the state is saved.