Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try turning off ignore_duplicate_files #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

bollwyvl
Copy link
Collaborator

Firefox was fixed in conda-forge, which is, i believe, the only reason we had ignore_duplicate_files in there. It's useful for making sure we don't have clobbery packages, but is usually okay to leave on.

firefox was fixed in conda-forge
@bollwyvl
Copy link
Collaborator Author

@datakurre been trying to help get jupyterlab-lsp tightened up: i haven't added https://github.com/tomi/vscode-rf-language-server to the PR but I think it will be worth investigating once released.

If the server bits were published on npm, we'd probably just have to add something like:

class RobotFrameworkLanguageServer(NodeModuleSpec):
    node_module = key = "rf-intellisense
    script = ["lib", "server.js"]
    languages = ["robot", "resource"]

and an entry_point, though it will be interesting to see what develops on https://github.com/rasjani/robotframework-rflsp (you know i ❤️ python)

@datakurre
Copy link
Contributor

datakurre commented Sep 30, 2019

Error: File 'Library/bin/api-ms-win-core-file-l1-2-0.dll' found in multiple packages: vs2015_runtime-15.5.2-3.tar.bz2, firefox-68.0.2-0.tar.bz2

Is vs2015_runtime there for WhiteLibrary?

@bollwyvl
Copy link
Collaborator Author

Yeah, the upstream PR only resulted in a patch upgrade (from 0 to <hash>_1). Because it's anaconda-primary, it's pulling that, and the new version has a runtime dependency on the conda-forge vs2015_runtime.

But, because channel priority, we're still pulling vs2015_runtime from anaconda, which cascades down the tree. I'm trying the conda-forge-first build locally, and just pushed. 🤞

If it doesn't work, we might be able to do some more exact surgery on the construct.yaml.in to force it.

@bollwyvl
Copy link
Collaborator Author

Ha, looks like it hasn't shown up on the repodata.json yet. That happens. Will do some more looking tomorrow.

@bollwyvl
Copy link
Collaborator Author

Is vs2015_runtime there for WhiteLibrary?

vs2015_runtime is for everything that is compiled with the microsoft compiler: for example, python, nodejs, etc. It's in basically every windows conda environment, so it's bad business if it gets clobbered. For our installer, it works because we test it, but if someone tried to conda install some-new-package-uilt-with-a-new-vs, it would create many problems. Once https://conda-forge.org/status is no longer showing degraded, we'll be right as rain, I'm hoping.

@bollwyvl
Copy link
Collaborator Author

from gitter:

CDN is back up. Packages should become available in the next 10-20 min. Haven't found the root cause of the issue yet, investigating

@bollwyvl
Copy link
Collaborator Author

looks legit: going to try rekicking...

$> CONDA_SUBDIR=win-64 conda create -n foo --dry-run -c conda-forge "firefox=68.0.2" python
Collecting package metadata (current_repodata.json): done
Solving environment: done

## Package Plan ##

  environment location: /home/weg/miniconda3/envs/foo

  added / updated specs:
    - firefox=68.0.2
    - python


The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    ca-certificates-2019.9.11  |       hecc5488_0         181 KB  conda-forge
    certifi-2019.9.11          |           py37_0         155 KB
    firefox-68.0.2             |       h6538335_1        60.4 MB  conda-forge
    openssl-1.1.1c             |       hfa6e2cd_0         4.7 MB  conda-forge
    pip-19.2.3                 |           py37_0         1.9 MB  conda-forge
    python-3.7.3               |       h510b542_1        17.7 MB  conda-forge
    setuptools-41.2.0          |           py37_0         652 KB  conda-forge
    sqlite-3.29.0              |       hfa6e2cd_1         1.1 MB  conda-forge
    vc-14.1                    |       h0510ff6_4           6 KB
    vs2015_runtime-14.16.27012 |       hf0eaf9b_0         1.1 MB
    wheel-0.33.6               |           py37_0          52 KB  conda-forge
    wincertstore-0.2           |        py37_1002          13 KB  conda-forge
    ------------------------------------------------------------
                                           Total:        88.0 MB

The following NEW packages will be INSTALLED:

  ca-certificates    conda-forge/win-64::ca-certificates-2019.9.11-hecc5488_0
  certifi            pkgs/main/win-64::certifi-2019.9.11-py37_0
  firefox            conda-forge/win-64::firefox-68.0.2-h6538335_1
  openssl            conda-forge/win-64::openssl-1.1.1c-hfa6e2cd_0
  pip                conda-forge/win-64::pip-19.2.3-py37_0
  python             conda-forge/win-64::python-3.7.3-h510b542_1
  setuptools         conda-forge/win-64::setuptools-41.2.0-py37_0
  sqlite             conda-forge/win-64::sqlite-3.29.0-hfa6e2cd_1
  vc                 pkgs/main/win-64::vc-14.1-h0510ff6_4
  vs2015_runtime     pkgs/main/win-64::vs2015_runtime-14.16.27012-hf0eaf9b_0
  wheel              conda-forge/win-64::wheel-0.33.6-py37_0
  wincertstore       conda-forge/win-64::wincertstore-0.2-py37_1002

@bollwyvl
Copy link
Collaborator Author

ha, now it's sharing paths with qt.

Error: File 'Library/bin/libEGL.dll' found in multiple packages: qt-5.12.5-h7ef1ec2_0.tar.bz2, firefox-68.0.2-h6538335_1.tar.bz2

to be fair, the qt is a relatively hot-and-fresh build of one of the hardest things to package (~6hr build). working on some minimal local reproducing...

@bollwyvl
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants