Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for latest version before execution #142

Open
aminvakil opened this issue Jan 10, 2022 · 8 comments
Open

Check for latest version before execution #142

aminvakil opened this issue Jan 10, 2022 · 8 comments

Comments

@aminvakil
Copy link
Contributor

There could be a soft warning which checks the latest migrate2rocky.sh from github and warns if it is not the latest one, this could help for other circumstances too IMHO.

This should definitely not be a barrier and force users to update as probably there are someones which execute this on local networks without internet access.

Not related to this issue but I could help creating a PR for this if you think it's useful.

Originally posted by @aminvakil in #141 (comment)

@aminvakil
Copy link
Contributor Author

Sure. I suppose it would first require us to actually set up version numbers for migrate2rocky, though.

Originally posted by @pajamian in #141 (comment)

@aminvakil
Copy link
Contributor Author

Sure. I suppose it would first require us to actually set up version numbers for migrate2rocky, though.

How about checking for differences between running migrate2rocky and latest from master?

Originally posted by @aminvakil in #141 (comment)

@aminvakil
Copy link
Contributor Author

The only real way to do that would be some sort of checksum, and that would be spoiled by any kind of local modification to the script.

Originally posted by @pajamian in #141 (comment)

@aminvakil
Copy link
Contributor Author

Let's continue here :)

Well it's a warning, right? They can skip the warning.

Also I'm not sure how versioning can help in this situtation.

@pajamian
Copy link
Collaborator

Well, versioning is on the todo list anyways (just sort of way down on the list). So it would make sense to me for this feature to use it.

@aminvakil
Copy link
Contributor Author

aminvakil commented Jan 10, 2022

So do you think this should wait out until versioning has been done?

@pajamian
Copy link
Collaborator

I'm more than happy if you want to add versioning as well. It could be as simple as just setting a variable at the top of the script and displaying it in the usage function.

@pajamian
Copy link
Collaborator

I'll set up versioning, and once I've done that you can look into this commit. I'll bump it up on my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants