Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not detect installation when installed via Rokit #96

Open
lrockreal opened this issue Jan 8, 2025 · 0 comments
Open

Comments

@lrockreal
Copy link

lrockreal commented Jan 8, 2025

Reproduction

  1. Open a new folder in VSCode and run rojo init in the terminal to make a rojo project.

  2. In the terminal, install rojo via Aftman in any of the following ways:

  • Running aftman add rojo
  • Installing rojo via the Rojo Command Pallete menu (CTRL+Shift+P)
  • Creating an aftman.toml file and add the following lines:
[tools]
rojo = "rojo-rbx/[email protected]" # replace 7.4.4 with latest or preferred version
  1. Open the Command Palette (CTRL+Shift+P) and open the Rojo menu. The Rojo extension sees Rojo as installed:

image

  1. Now rename aftman.toml to rokit.toml. (Both files support the same format)

  2. Open the Command Palette again and open the Rojo menu. The Rojo extension now sees Rojo as not installed:

image

  1. Navigate to the Install Rojo now option and click it. The Rojo extension should now be installed via both Aftman and Rokit:

image

Explanation

Rojo can detect its own installation via Aftman but not via Rokit.

This issue may also require some feedback:

  • During installation the user could be asked which toolchain manager they prefer (Foreman, aftman, rokit)
  • The extension could also choose to prefer rokit in new projects as rojo seems to be pushing people to migrate to their tool
  • Should the extension should a migration popup like the one shown when Foreman is installed?

This is related to #91. I have not checked if #94 addresses all the issues in this post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant