Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-resolve): add ignoreSideEffectsForRoot to exported interface #1841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(node-resolve): add ignoreSideEffectsForRoot to exported interface #1841

wants to merge 1 commit into from

Conversation

younggglcy
Copy link
Contributor

Rollup Plugin Name: @rollup/plugin-node-resolve

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

fix #1824

Description

This PR supplies definitions of ignoreSideEffectsForRoot to the exported interface RollupNodeResolveOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjenkinson tjenkinson Awaiting requested review from tjenkinson tjenkinson is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@rollup/plugin-node-resolve] RollupNodeResolveOptions interface doesn't include ignoreSideEffectsForRoot
1 participant
@younggglcy