Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 Support with npm 8 #130

Open
ajGingrich opened this issue Jun 1, 2022 · 1 comment
Open

React 17 Support with npm 8 #130

ajGingrich opened this issue Jun 1, 2022 · 1 comment

Comments

@ajGingrich
Copy link

ajGingrich commented Jun 1, 2022

This currently works well with React 17 but it cannot be installed using npm 8 because the peer dependencies do not support React 17.

Solution: change the peer dependencies to the following.

  "peerDependencies": {
    "react": ">=16",
    "react-dom": ">=16"
  },

I can make this change if you'll accept a PR.

@snellcode
Copy link

snellcode commented Jan 31, 2024

similar issue for me using preact 10, which I think is emulating react 18. Everything works fine, but I do get these warnings:

warning " > [email protected]" has incorrect peer dependency "react@^16.6.0".
warning " > [email protected]" has incorrect peer dependency "react-dom@^16.6.0".

This is a great package, and I will keep using it because it does what I want. But still would be nice to remove these warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants