Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option filter-changed-files set to true doesn't show anything #47

Open
ivanzusko opened this issue Aug 5, 2022 · 2 comments
Open

Option filter-changed-files set to true doesn't show anything #47

ivanzusko opened this issue Aug 5, 2022 · 2 comments

Comments

@ivanzusko
Copy link

I've added a dummy function and didn't cover it with tests and the changed file wasn't reported in the end (even though the overall coverage was shown)

- name: Post coverage report
        uses: romeovs/[email protected]
        with:
          lcov-file: "${{ env.WORKING_DIRECTORY }}/coverage/lcov_head.info"
          lcov-base: "${{ env.WORKING_DIRECTORY }}/coverage/lcov.info"
          github-token: "${{ secrets.SA_GITHUB_TOKEN }}"
          delete-old-comments: true
          filter-changed-files: true

image

@pcothenet
Copy link

It looks like the release adding this option never got published: https://github.com/romeovs/lcov-reporter-action/actions/runs/1529380626

@fredrikaverpil
Copy link

fredrikaverpil commented Dec 22, 2022

I worked around this by using the commit sha as GHA version:

      - uses: romeovs/lcov-reporter-action@2a28ec3e25fb7eae9cb537e9141603486f810d1a
        # The reason for using a hash rather than a version/tag, is the project
        # failed in publishing this release: https://github.com/romeovs/lcov-reporter-action/issues/47
        with:
          lcov-file: ./coverage/coverage.lcov
          filter-changed-files: true
          delete-old-comments: true

image

I posted a full setup example over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants