Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Treesitter highlight groups #3

Open
ilAYAli opened this issue Feb 3, 2021 · 3 comments
Open

support Treesitter highlight groups #3

ilAYAli opened this issue Feb 3, 2021 · 3 comments

Comments

@ilAYAli
Copy link

ilAYAli commented Feb 3, 2021

Support for Treesitter highlight groups would be much appreciated:

TSError
TSPunctDelimiter
TSPunctBracket
TSPunctSpecial
TSConstant
TSConstBuiltin
TSConstMacro
TSStringRegex
TSString
TSStringEscape
TSCharacter
TSNumber
TSBoolean
TSFloat
TSAnnotation
TSAttribute
TSNamespace
TSFuncBuiltin
TSFunction
TSFuncMacro
TSParameter
TSParameterReference
TSMethod
TSField
TSProperty
TSConstructor
TSConditional
TSRepeat
TSLabel
TSKeyword
TSKeywordFunction
TSKeywordOperator
TSOperator
TSException
TSType
TSTypeBuiltin
TSStructure
TSInclude
TSVariable
TSVariableBuiltin
TSText
TSStrong
TSEmphasis
TSUnderline
TSTitle
TSLiteral
TSURI
TSTag
TSTagDelimiter
TSNone
TSQueryLinterError
@romgrk
Copy link
Owner

romgrk commented Feb 11, 2021

Doesn't treesitter fallbacks on standard groups?

Also note that I'm not using this colorscheme at the moment so I'm unlikely to implement this. I might do it if I come back to this colorscheme but for now I'm with the dark side. I'd accept a PR though.

@ilAYAli
Copy link
Author

ilAYAli commented Feb 11, 2021

@romgrk yes, treesitter has fallback to standard groups, but additional highlight groups makes for a much better experience.
I am usually on the darker side too, but this is my preferred theme; outside, on a bright summer day, with a beer in my hand, and laptop on my ....lap. Sadly, that is a few months into the future.

@romgrk
Copy link
Owner

romgrk commented Feb 12, 2021

I totally understand it, it's also my favourite light theme.

I will put it in my todo list and will try to get it done by this summer. I'll probably be updating my dark theme at the same time, both themes are forks of each other so adding the groups to one makes it trivial to add them to the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants