Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer to peer code review - 24/01/2023 #4

Open
ram1117 opened this issue Jan 24, 2023 · 1 comment
Open

peer to peer code review - 24/01/2023 #4

ram1117 opened this issue Jan 24, 2023 · 1 comment

Comments

@ram1117
Copy link

ram1117 commented Jan 24, 2023

Hi Rony, great work completing the project. The team would like to make the following suggestion for your project.

1.The module toDoTasks can be combined with local storage module.
2.The remove tasks functionality seems to have a problem. Once several tasks are removed using remove completed tasks button and a new task is added, the removed tasks reappear in the screen as well as local storage. Can you check this. PFB screen capture for reference.

codereview
@roniy68
Copy link
Owner

roniy68 commented Jan 24, 2023

Thanks For The Review

I noticed the issue. And Will close this issue as soon as i solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roniy68 @ram1117