Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not able to exit from rkt cli #4

Open
owlreddy opened this issue Oct 25, 2020 · 5 comments
Open

not able to exit from rkt cli #4

owlreddy opened this issue Oct 25, 2020 · 5 comments

Comments

@owlreddy
Copy link

Description:
I'm not able to exit from rkt cli with an exit command or the recommended logout command

Steps to reproduce the behavior:

  1. Install Roost on Linux (my pc details are at the end of this thread)
  2. Open roost and wait for rkt to spin up
  3. Open an rkt terminal and try to exit with "exit" or Ctrl+D or "logout" command

Expected behavior:
expecting Ctrl+D to close the current rkt terminal

Link to Screenshot:
https://photos.google.com/share/AF1QipP4VtvlfYChDRZGOY6itpT1ra9CKy5dn_UC81QJNYdGLfO_GXnM4od886p6Lz7jfg/photo/AF1QipOYp3Ss7w4XnB6D25yIBGwfv91a1hfkTPxyQchd?key=UDJBdjYxX2ZwcFY4MGFjRXdHTzJOLUxqNkFvTUh3

Desktop:
Operating System: Pop!_OS 20.10
Kernel: Linux 5.8.0-7625-generic
Architecture: x86-64

Additional context
Ideally would like to see exit and Ctrl+D working rather than unfamiliar logout for terminal exit

@harishagrawal
Copy link
Contributor

harishagrawal commented Oct 25, 2020 via email

@owlreddy
Copy link
Author

Enable exit && exit
or
enable logout && logout works but I'm still reverting back to my original terminal.
From my terminal also exit command doesn't close the terminal window. Here is a Screenshot
So the only way seems to be to use the cross mark for closing window

@owlreddy
Copy link
Author

owlreddy commented Oct 25, 2020

Ideally:

  1. It would be good to have exit and logout enabled by default.
  • Because closing an rkt terminal doesn't terminate the rkt engine, so there's no issue even if we close the terminal accidentally. We can just reconnect.
  1. Would love to see Ctrl+D or exit close the terminal window completely(action which now only happens when we click cross(x) mark) and logout would switch back to my original terminal.
  • The above logout point has a concern, reverting to my original terminal wouldn't change the window name which is "rkt-terminal" by default for rkt terminals.
  • So, not just disabling but also removing logout command from rkt-engine is also an option. Since if i want a terminal i can open a terminal directly as roost supports it.

@harishagrawal
Copy link
Contributor

We will look at option of mapping the exit buttons to behave like the cross(x) mark so as to avoid landing on the regular terminal

@owlreddy
Copy link
Author

Great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants