Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Return descriptive error codes from e2e tests #140

Open
3 tasks
prajakta-gokhale opened this issue Apr 20, 2020 · 1 comment
Open
3 tasks

Return descriptive error codes from e2e tests #140

prajakta-gokhale opened this issue Apr 20, 2020 · 1 comment
Labels
good first issue Good for newcomers technical debt Code that could use some cleanup or refactoring, not necessarily a new feature

Comments

@prajakta-gokhale
Copy link
Member

Description

The e2e tests in this package return a numeric return code of 0 for success and 1 otherwise. This does not help identify the cause of build failures easily, without looking at the long logs produced.

Refactor the return code part in system_metrics_e2e_test and topic_statistics_e2e_test to make the failure code less generic and more descriptive of the cause of failure.

Originally posted by @dabonnie in https://github.com/ros-tooling/system_metrics_collector/pull/125/files

Test Plan

  • Manual testing of new return codes

Documentation Plan

  • Document the return codes in e2e tests

Release Plan

  • Check in PR

Acceptance Criteria

  • Code has been implemented, reviewed and merged.
  • Test plan has been completed
  • Release plan has been completed

Once all above items are checked, this story can be moved to done.

Resources

@prajakta-gokhale prajakta-gokhale added good first issue Good for newcomers technical debt Code that could use some cleanup or refactoring, not necessarily a new feature labels Apr 20, 2020
@dabonnie
Copy link
Contributor

Some context why descriptive return codes are useful: ros-tooling/action-ros-ci#143

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers technical debt Code that could use some cleanup or refactoring, not necessarily a new feature
Projects
None yet
Development

No branches or pull requests

2 participants