Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Increase palette contrast #110

Open
ThatOneCalculator opened this issue May 14, 2023 · 3 comments
Open

RFC: Increase palette contrast #110

ThatOneCalculator opened this issue May 14, 2023 · 3 comments

Comments

@ThatOneCalculator
Copy link
Member

I've seen a lot of complaints about contrast/visual accessibility with Rose Pine Dawn, and I agree. I think the purple-on-cream doesn't provide enough contrast to those with limited color vision, and I think changing #575279 to something more like #3D3A55 or even #464261 would be good.

@mvllow
Copy link
Member

mvllow commented May 15, 2023

I am happy to discuss here or in our Discord on ways to make both Dawn and Moon more accessible—with all colours, not just the text colour. These variants were made with WCAG AA compliance in mind but I would have to confirm with each colour if this is accurate or not. The Dawn text colour is AA on base and AAA on surface (at "normal" text size, according to https://color.a11y.com/ContrastPair/?bgcolor=faf4ed&fgcolor=575279).

Feedback from anyone affected, including yourself, would be much appreciated on if WCAG AAA (7:1 contrast ratio) is a good metric to judge the accessibility or not. If so, I will change any value necessary to meet that criteria :)

Of course, a WCAG rating doesn't have to be the final factor—if something has a passing 7:1 contrast ratio but is still inaccessible I would consider higher contrast for most palette options.

Thank you for bringing this up. This is an important topic that we've seen brought up about other variants and colours as well.

Edit: Added a discussion on Discord https://discord.com/channels/1090681740865052722/1107674766577516686/1107674766577516686

@mvllow mvllow changed the title Consider increasing Rose Pine Dawn contrast RFC: Increase palette contrast Jul 28, 2023
@mvllow
Copy link
Member

mvllow commented Jul 28, 2023

I've been using #464261 for some time now in my Neovim/Kitty and quite enjoy the increased contrast.

I'm wondering if we should try to address the main variant's pine as well—using pine from moon looks good but would make the only difference between main/moon accents rose, which feels odd.

@DannyJJK
Copy link

The main color I struggle with is the gold text in Rose Pine Dawn. It seems to blend into the Dawn background a lot more than the other colours on my MacBook Pro 2019 monitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants