diff --git a/CHANGES.txt b/CHANGES.txt index 175fdc64..e235cedd 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -87,6 +87,10 @@ Fixed: supplied the fix. John Rouillard committed) - issue1895197 - translated help texts in admin.py not displayed correctly. (Initial patch tobias-herp, John Rouillard) +- issue2551238 - roundup-server should exit with error if -d + is used without -l . Added code to report + the issue. Added issue with relative paths for log file whn + using -L and -d with roundup-server. (John Rouillard) Features: diff --git a/doc/admin_guide.txt b/doc/admin_guide.txt index 726b4bc8..43c4c050 100644 --- a/doc/admin_guide.txt +++ b/doc/admin_guide.txt @@ -223,6 +223,20 @@ Additional notes for each keyword: ``-----END CERTIFICATE-----``. If not specified, roundup will generate a temporary, self-signed certificate for use. +**loghttpvialogger** section + If you: + + * have **loghttpvialogger** enabled + * use **pidfile** + * use a logging config file in the tracker's config.ini + + it is essential to specify absolute paths for log files in the + tracker's logging.config file. The use of pidfile causes the + server to switch to the root directory ('/'). As a result + relative paths in the logging ini configuration file (as + opposed to the tracker's config.ini) will be written to the + system's root directory. The access error will cause the server + to exit. **trackers** section Each line denotes a mapping from a URL component to a tracker home. Make sure the name part doesn't include any url-unsafe characters like diff --git a/roundup/scripts/roundup_server.py b/roundup/scripts/roundup_server.py index 97ccbf91..c8aa6c2a 100644 --- a/roundup/scripts/roundup_server.py +++ b/roundup/scripts/roundup_server.py @@ -1198,6 +1198,9 @@ def run(port=undefined, success_message=None): config.set_logging() if config["PIDFILE"]: config["PIDFILE"] = os.path.abspath(config["PIDFILE"]) + if not (config["LOGFILE"] or config["LOGHTTPVIALOGGER"]): + print(_("If you specify a PID file you must use -l or -L.")) + sys.exit(1) # fork the server from our parent if a pidfile is specified if config["PIDFILE"]: