4.3: build fails

[kloczek]

Looks like something is wrrong with Makefile rules for man pages

+ ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --disable-silent-rules --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --runstatedir=/run --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --enable-reduced-depends --enable-setpag --with-aklog=/usr/bin/aklog
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for x86_64-redhat-linux-gnu-gcc... /usr/bin/gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether /usr/bin/gcc accepts -g... yes
checking for /usr/bin/gcc option to enable C11 features... none needed
checking whether /usr/bin/gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of /usr/bin/gcc... none
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for wchar.h... yes
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether _XOPEN_SOURCE should be defined... no
checking if the compiler is Clang... no
checking if /usr/bin/gcc supports -fstrict-overflow... yes
checking if /usr/bin/gcc supports -fstrict-aliasing... yes
checking if /usr/bin/gcc supports -Wall... yes
checking if /usr/bin/gcc supports -Wextra... yes
checking if /usr/bin/gcc supports -Wformat=2... yes
checking if /usr/bin/gcc supports -Wformat-overflow=2... yes
checking if /usr/bin/gcc supports -Wformat-signedness... yes
checking if /usr/bin/gcc supports -Wformat-truncation=2... yes
checking if /usr/bin/gcc supports -Wnull-dereference... yes
checking if /usr/bin/gcc supports -Winit-self... yes
checking if /usr/bin/gcc supports -Wswitch-enum... yes
checking if /usr/bin/gcc supports -Wstrict-overflow=5... yes
checking if /usr/bin/gcc supports -Wmissing-format-attribute... yes
checking if /usr/bin/gcc supports -Walloc-zero... yes
checking if /usr/bin/gcc supports -Wduplicated-branches... yes
checking if /usr/bin/gcc supports -Wduplicated-cond... yes
checking if /usr/bin/gcc supports -Wtrampolines... yes
checking if /usr/bin/gcc supports -Wfloat-equal... yes
checking if /usr/bin/gcc supports -Wdeclaration-after-statement... yes
checking if /usr/bin/gcc supports -Wshadow... yes
checking if /usr/bin/gcc supports -Wpointer-arith... yes
checking if /usr/bin/gcc supports -Wbad-function-cast... yes
checking if /usr/bin/gcc supports -Wcast-align... yes
checking if /usr/bin/gcc supports -Wwrite-strings... yes
checking if /usr/bin/gcc supports -Wconversion... yes
checking if /usr/bin/gcc supports -Wno-sign-conversion... yes
checking if /usr/bin/gcc supports -Wdate-time... yes
checking if /usr/bin/gcc supports -Wjump-misses-init... yes
checking if /usr/bin/gcc supports -Wlogical-op... yes
checking if /usr/bin/gcc supports -Wstrict-prototypes... yes
checking if /usr/bin/gcc supports -Wold-style-definition... yes
checking if /usr/bin/gcc supports -Wmissing-prototypes... yes
checking if /usr/bin/gcc supports -Wmissing-declarations... yes
checking if /usr/bin/gcc supports -Wnormalized=nfc... yes
checking if /usr/bin/gcc supports -Wpacked... yes
checking if /usr/bin/gcc supports -Wredundant-decls... yes
checking if /usr/bin/gcc supports -Wrestrict... yes
checking if /usr/bin/gcc supports -Wnested-externs... yes
checking if /usr/bin/gcc supports -Winline... yes
checking if /usr/bin/gcc supports -Wvla... yes
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking for x86_64-redhat-linux-gnu-ar... /usr/bin/gcc-ar
checking the archiver (/usr/bin/gcc-ar) interface... ar
checking for x86_64-redhat-linux-gnu-ranlib... /usr/bin/gcc-ranlib
checking size of long... 8
checking for krb5_init_context in -lkrb5... yes
checking for krb5_get_error_message... yes
checking for krb5_free_error_message... yes
checking for krb5.h... yes
checking for kerberosv5/krb5.h... no
checking for krb5/krb5.h... yes
checking for krb5_cc_copy_cache... no
checking for krb5_cc_get_full_name... yes
checking for krb5_get_init_creds_opt_alloc... yes
checking for krb5_get_init_creds_opt_set_default_flags... no
checking for krb5_principal_get_realm... no
checking for krb5_xfree... no
checking for krb5_get_init_creds_opt_free... yes
checking if krb5_get_init_creds_opt_free takes two arguments... yes
checking for /usr/bin/gcc options needed to detect all undeclared functions... none needed
checking whether krb5_kt_free_entry is declared... yes
checking for krb5_get_renewed_creds... yes
checking build system type... x86_64-redhat-linux-gnu
checking host system type... x86_64-redhat-linux-gnu
checking for sys/ioccom.h... no
checking for k_hasafs in -lkafs... no
checking for k_hasafs in -lkopenafs... no
checking for k_pioctl... no
checking for k_haspag... no
checking for x86_64-redhat-linux-gnu-pkg-config... no
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for LIBKEYUTILS... yes
checking for _Bool... yes
checking for stdbool.h that conforms to C99... yes
checking for strings.h... (cached) yes
checking for sys/bitypes.h... yes
checking for sys/select.h... yes
checking for sys/time.h... yes
checking for syslog.h... yes
checking whether reallocarray is declared... yes
checking for C99 variadic macros... yes
checking for GNU-style variadic macros... yes
checking for unsigned long long int... yes
checking for long long int... yes
checking for uint32_t... yes
checking for sig_atomic_t... yes
checking for ssize_t... yes
checking for explicit_bzero... yes
checking for setrlimit... yes
checking for setsid... yes
checking for asprintf... yes
checking for daemon... yes
checking for mkstemp... yes
checking for reallocarray... yes
checking for setenv... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing tests/data/.placeholder commands
+ /usr/bin/make -O -j48 V=1 VERBOSE=1
/usr/bin/make  all-am
make[1]: *** No rule to make target 'docs/k5start.1', needed by 'all-am'.  Stop.
make[1]: *** Waiting for unfinished jobs....
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/kstart-release-4.3'
/usr/bin/gcc -DHAVE_CONFIG_H -I.       -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -Os -c -o commands/krenew-krenew.o `test -f 'commands/krenew.c' || echo './'`commands/krenew.c
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/kstart-release-4.3'
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/kstart-release-4.3'
/usr/bin/gcc -DHAVE_CONFIG_H -I.       -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -Os -c -o commands/krenew-framework.o `test -f 'commands/framework.c' || echo './'`commands/framework.c
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/kstart-release-4.3'
make: *** [Makefile:709: all] Error 2

[rra]

Is this from a Git checkout? If so, you need to run the bootstrap script at the top of the source tree, which generates the manual pages. (They're included in the distribution tarball so normally don't need to be built.)

[kloczek]

Here is quick fix for that issue:

--- a/Makefile.am~      2021-08-31 04:42:03.000000000 +0100
+++ b/Makefile.am       2021-09-16 20:44:49.935615111 +0100
@@ -174,3 +175,7 @@
 # Used by maintainers to reformat all source code using clang-format.
 reformat:
        find . -name '*.[ch]' -print | xargs clang-format -style=file -i
+
+MAMS = docs/k5start.1 docs/krenew.1
+$(MANS): docs/%.1: docs/%.pod
+       pod2man --release="version $(VERSION)" --center="kstart" $< > $@
--- a/bootstrap~        2021-08-31 04:42:03.000000000 +0100
+++ b/bootstrap 2021-09-16 21:10:01.137440134 +0100
@@ -12,11 +12,4 @@
 set -e

 # Regenerate all the autotools files.
-autoreconf -i --force
-
-# Generate manual pages.
-version=`grep '^kstart' NEWS | head -1 | cut -d' ' -f2`
-pod2man --release="$version" --center="kstart" docs/k5start.pod \
-    >docs/k5start.1
-pod2man --release="$version" --center="kstart" docs/krenew.pod \
-    >docs/krenew.1
+autoreconf -fiv

Please let me know if you want that patch as PR.

[kloczek]

Advantage of that modyfication is that if it will be necessary to regenerate man page after .pod files modyficayion make will take care of that automatiically (basing on files time stams).

[rra]

Yeah, on further consideration I should start doing this in all of my packages. I had originally avoided it because I was afraid timestamp ordering issues would trigger a spurious dependency on Perl during a build of a package that otherwise doesn't require Perl, but maybe I should just trust the timestamps in generated releases, plus availability of Perl is fairly universal and having a complete dependency tree is certainly better.

A PR would be welcome and then I can give you credit in Git. Thanks!

[rra]

That said, please don't remove the man page generation from bootstrap. I think the right fix is to put it in both places, since the build of kstart should not depend on Perl.

[kloczek]

Yeah, on further consideration I should start doing this in all of my packages. I had originally avoided it because I was afraid timestamp ordering issues would trigger a spurious dependency on Perl during a build of a package that otherwise doesn't require Perl, but maybe I should just trust the timestamps in generated releases, plus availability of Perl is fairly universal and having a complete dependency tree is certainly better.

So convert man pages to xml and use xsltptoc to generate man pages :P
Nebertheless I've mention about time stams and make regeneraring man pages as part of the devel env behaviour .. not as regular build :)
If generated man pages will be in dist ratr ball generated by make distcheck it will be no need to regenerate those man pages durung regular build.