Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on string enums doesn't stick around #1

Open
rrbutani opened this issue May 17, 2020 · 2 comments
Open

Documentation on string enums doesn't stick around #1

rrbutani opened this issue May 17, 2020 · 2 comments
Assignees
@rrbutani
Labels
external Blocked on something external
Milestone
4.7.0

Comments

@rrbutani
Copy link
Owner

Since we're using #![deny(missing_docs)] this makes the build fail.
@rrbutani
Copy link
Owner Author

Some of the lints we're using also get mad at the code wasm-bindgen generates; specifically missing_docs and unsafe_code.

@rrbutani
Copy link
Owner Author

Fixed in rustwasm/wasm-bindgen#2141.

Right now we use the fork of wasm-bindgen that's in the PR but once it gets merge we should switch back to upstream. Until that happens, I'm leaving this issue open.

@rrbutani rrbutani self-assigned this May 17, 2020
@rrbutani rrbutani mentioned this issue May 26, 2020
Open
@rrbutani rrbutani added the external Blocked on something external label May 26, 2020
@rrbutani rrbutani added this to the 4.7.0 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrbutani rrbutani

Labels
external Blocked on something external
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
1 participant
@rrbutani