Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSK Urls and Name changes #354

Open
wants to merge 1,237 commits into
base: master
Choose a base branch
from
Open

RSK Urls and Name changes #354

wants to merge 1,237 commits into from

Conversation

MaximStanciu8
Copy link
Collaborator

Title of pull request

The pull request should be described here

Description

  • Describe here your pull request modifications
  • It could be more than one thing

How to Test

  • Run both ganache-cli
  • Enter into the bridge directory and run all the tests

Case 1

  1. Go to bridge directory
$~ cd bridge
  1. Run all the tests
$~ npm run test

Expected Result

  • It should pass the test
    image
  1. Run the first ganache-cli
$~ npm run ganache
  1. Open another shell and run the ganache mirror
$~ npm run ganache-mirror
  1. Go to the federator directory
$~ cd ../federator
  1. Run the integration test
$~ npm run integrationTest

Expected Result

  • It should pass the test
    image
  1. Run the integration test
$~ npm run integrationTest

Expected Result

  • It should pass the test
    image

Case N...

Checklist

Bridge Directory cd bridge

  • [] Lint is clean npm run lint
  • [] Test is passing npm run test
  • [] Contracts are compiling npm run compile

Federator Directory cd federator

  • [] Lint is clean npm run lint
  • [] Test is passing npm run test
  • [] Typescript is compiling npm run build

RafilxTenfen and others added 30 commits March 4, 2022 15:38
@RafilxTenfen
set federator to run again
43c0ca8
@RafilxTenfen
set federator to run again
6f192be
@RafilxTenfen
removed unused variable
626175f
@RafilxTenfen
init refactory of integration test
1b4ca0a
@RafilxTenfen
refactory for checkAddressBalance
4ba6eec
@RafilxTenfen
refactory for checkTxDataHash
764d152
@RafilxTenfen
refactory for checkTxDataHash
224b134
@RafilxTenfen
refactory for sendFederatorTx
d65cb93
@RafilxTenfen
fix const value being reassign
1cd534e
@RafilxTenfen
fix code sonar cloud code smells
76ddf15
@RafilxTenfen
fix sonar cloud code smells
d7e7313
@RafilxTenfen
fix mkdir sync error and sonar cloud code smells
0783bc0
@RafilxTenfen
fix sonar cloud code smells
024f7bc
@RafilxTenfen
refactory check balances
a381e16
@RafilxTenfen
refactory run federators
a6d70ee
@RafilxTenfen
refactory transferBackTokens
8df95bd
@RafilxTenfen
refactory transferCheckStartErc777
ccb1a96
@RafilxTenfen
refactory transferCheckErc777ReceiveTokensOtherSide
b2e1979
@RafilxTenfen
refactory tranferCheckAmounts
a82bd6e
@RafilxTenfen
refactory callReceiveTokens
c818dbd
@RafilxTenfen
fix code smells
721e30f
@RafilxTenfen
fix code smells
d2fde14
@RafilxTenfen
refactory of claimLargeAmounts
6addfb9
@RafilxTenfen
refactory of transferCheckSendingTokens
92c4f7b
@RafilxTenfen
fix code smells
8b613ed
@RafilxTenfen
refactory transferChecks
7f96727
@RafilxTenfen
refactory transfer
4c05018
Add Datadog metric tracking for heartbeat and federators
fd1c5e1
Update bridge's package-lock.json, handle error cases when using metr…
934948e 
…ic collector (env variable not set, undefined metric collector, etc.)
Add Datadog documentation to Federation README
abc13ee
joaoiovlabs and others added 26 commits April 29, 2022 10:31
@joaoiovlabs
Remove utils.tokenType from tests Federation_test.js
0209382
@joaoiovlabs
Merge branch 'master' of github.com:rsksmart/tokenbridge into GBI-543…
0079db2 
…_Federator_Remove_all_code_related_to_NFT_support
@joaoiovlabs
Remove all references of BINANCE.
475cb32
@augustoIOV
Merge pull request rsksmart#336 from rsksmart/GBI-543_Federator_Remov…
c2cd5f6 
…e_all_code_related_to_NFT_support

GBI-543 - Federator: Remove all code related to NFT support
@juan-rsk
Syntax error fixed on testnet workflow
e27c379
@augustoIOV
Merge pull request rsksmart#338 from rsksmart/juantelez/fix-CD
d899c77 
Syntax error fixed on testnet workflow
@joaoiovlabs
Merge branch 'master' of github.com:rsksmart/tokenbridge into GBI_540…
10a0b57 
…_Federator_Remove_functionality_related_to_binance
@augustoIOV
Merge pull request rsksmart#337 from rsksmart/GBI_540_Federator_Remov…
c79fcd8 
…e_functionality_related_to_binance

GBI 540: Federator Remove functionality related to binance
@gsoares85
Removed federator.key and added a env var for that
c8678f6
@augustoIOV
update deployment info
02ac464
@augustoIOV
Merge remote-tracking branch 'origin/master' into update_deployment_info
cfa1316
@gsoares85
Fixed ununsed vars warning
c3e37e1
@augustoIOV
Merge pull request rsksmart#340 from rsksmart/update_deployment_info
8e77d9b 
Update deployment info
@gsoares85
Fixed ununsed values and create env.example
c049ab2
@augustoIOV
Merge pull request rsksmart#339 from rsksmart/feature/GBI-644-Move-fe…
c3dfbc8 
…derator.key-To-An-Env-Var

Removed federator.key and added a env var for that
@lucasvuotto
Fix ECS task executionRoleArn, cpu and memory paramters
2fe2604
@augustoIOV
Merge pull request rsksmart#341 from lucasvuotto/fix/ecs-task-executi…
358a2ef 
…on-role

Fix ECS task executionRoleArn, cpu and memory paramters
@lucasvuotto
Fix GitHub workflow ECS_SERVICE value
0a5d4b1
@augustoIOV
Merge pull request rsksmart#342 from lucasvuotto/fix/ecs-service-name
33abc79 
Fix GitHub workflow ECS_SERVICE value
@lucasvuotto
Deploy improvements
d6aff67 
- Rename .aws/task-definition.json -> .aws/testnet.json
- Fix container image source
- Fix container log group and prefix
@augustoIOV
Merge pull request rsksmart#343 from lucasvuotto/fix/ecs-awslogs-group
1b68ae2 
Deploy improvements
@lucasvuotto
Rework Dockerfile
e4438a4
@augustoIOV
Merge pull request rsksmart#344 from lucasvuotto/fix/docker-build
297ed54 
Rework Dockerfile
@gsoares85
Added more information to reverted transaction log
8fbcb8b
@gsoares85
Merge pull request rsksmart#349 from rsksmart/feature/GBI-875-createL…
86af496 
…ogForPending

Added more information to reverted transaction log
@maximstanciu
RSK Urls and Name changes
777c5de
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nicolasegimenez
nicolasegimenez approved these changes May 18, 2023
View reviewed changes
Copy link

@nicolasegimenez nicolasegimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important change since rebranding. Please add a descriptive documentation for the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasegimenez nicolasegimenez nicolasegimenez approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.