From f00bd9fbf0da890d743d81c0c9fd00c907e59bbf Mon Sep 17 00:00:00 2001 From: Carson Date: Tue, 31 Oct 2023 09:57:18 -0500 Subject: [PATCH 1/2] Update tabPanel() snapshot tests in anticipation of bslib release --- tests/testthat/_snaps/tabPanel.md | 136 +++++++++++++++--------------- tests/testthat/test-tabPanel.R | 2 +- 2 files changed, 71 insertions(+), 67 deletions(-) diff --git a/tests/testthat/_snaps/tabPanel.md b/tests/testthat/_snaps/tabPanel.md index 139973421a..bc0f402265 100644 --- a/tests/testthat/_snaps/tabPanel.md +++ b/tests/testthat/_snaps/tabPanel.md @@ -182,84 +182,88 @@ Code nav_page Output - -
-
-
a
-
b
-
c
-
+ --- Code bslib_tags(x) Output - -
-
-
a
-
b
-
c
-
+ # String input is handled properly diff --git a/tests/testthat/test-tabPanel.R b/tests/testthat/test-tabPanel.R index 03149c7cee..0c03f6bc44 100644 --- a/tests/testthat/test-tabPanel.R +++ b/tests/testthat/test-tabPanel.R @@ -1,7 +1,6 @@ # tabsetPanel() et al. use p_randomInt() to generate ids (which uses withPrivateSeed()), # so we need to fix Shiny's private seed in order to make their HTML output deterministic navlist_panel <- function(...) { - withPrivateSeed(set.seed(100)) navlistPanel(...) } @@ -31,6 +30,7 @@ expect_snapshot_bslib <- function(x, ...) { # Simulates the UI tags that would be produced by # shinyApp(bootstrapPage(theme), function(...) {}) bslib_tags <- function(ui, theme = bslib::bs_theme()) { + skip_if_not_installed("bslib", "0.5.1.9000") old_theme <- getCurrentTheme() on.exit(setCurrentTheme(old_theme), add = TRUE) setCurrentTheme(theme) From f105b470e794d5201b77241a66cdc871f92abf46 Mon Sep 17 00:00:00 2001 From: cpsievert Date: Wed, 29 Nov 2023 21:32:37 +0000 Subject: [PATCH 2/2] `yarn build` (GitHub Actions) --- yarn.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/yarn.lock b/yarn.lock index 6d52448a7f..7f167791ce 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1853,7 +1853,7 @@ __metadata: peerDependenciesMeta: jquery-ui: optional: true - checksum: 8718ebda1068894fc1267459b603f492045723ed1000fdbe798f2fab78fed8536b1906f56c53e9bd0ff9dce24aed176045618d0a1eddcf48f7d0313ad4ad67e9 + checksum: ba260ba5804c16b1455ff79f9d00ce860e12ae36e29d7a5f702da6b384c9454497421b8e06fe683d10fac53e2dc6ec008da4fa129a153cbbfe5396e027eb4247 languageName: node linkType: hard