Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease developpper addition of new models through new_model_vetiver(model_class = "your_object", package_name = "your_package") #125

Closed
cregouby opened this issue Jul 14, 2022 · 3 comments
Labels
feature a feature request or enhancement

Comments

@cregouby
Copy link

... exactly as {butcher} propose a new_model_butcher(model_class = "your_object", package_name = "your_package").
This would ensure homogeneous code base and tests templates

@juliasilge
Copy link
Member

We could definitely do this, probably using cli's support for this kind of code generation.

I do wonder how many more kinds of models we may end supporting, and if this developer-facing tooling would be a good investment. What kind of model are you interested in having vetiver support?

@juliasilge juliasilge added the feature a feature request or enhancement label Jul 15, 2022
@cregouby
Copy link
Author

The kind of model I'm thinking of is tabnet: #124, and maybe, later on, other models from packages in mlverse ecosystem...

@juliasilge
Copy link
Member

I don't expect that we'll have such a large pool of models being added to vetiver (especially since we already support tidymodels, caret, mlr3, etc) that this will be a high need moving forward. Thank you for your input! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants