Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate-limit including warning message? #880

Open
jvymazal opened this issue Jan 13, 2020 · 4 comments
Open

Rate-limit including warning message? #880

jvymazal opened this issue Jan 13, 2020 · 4 comments

Comments

@jvymazal
Copy link
Contributor

During testing we found that if you set Ratelimit.Burst for example 10 messages and you test for that 10 messages to arrive you get only 9 messages and message telling you that 1 message was lost due to rate-limiting. Is this intentional?
I am opening it here under documentation as I do not think it makes much sense to change the code as it is very unlikely to cause any problem for any real use-case, however from current documentation state one would expect the numbers to match exactly.
@jvymazal
Copy link
Contributor Author

@rgerhards Is there some good central place for this information to be put in?

@jvymazal
Copy link
Contributor Author

@rgerhards slight bump, any idea or opinion on above please?

@rgerhards
Copy link
Member

@jvymazal sorry, I am part of the Covid-19 crisis team in our community. Ultra busy... will try to look whenever I find some time

@jvymazal
Copy link
Contributor Author

ok, understood, take care and wish you luck in handling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgerhards @jvymazal