Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to cite sources? #87

Closed
andyw8 opened this issue Apr 27, 2019 · 4 comments
Closed

How to cite sources? #87

andyw8 opened this issue Apr 27, 2019 · 4 comments

Comments

@andyw8
Copy link
Contributor

andyw8 commented Apr 27, 2019

For example:

Use :context instead of the ambiguous :all scope in before/after hooks.

There's a section in Effective Testing With RSpec 3 which provides similar advice:

https://books.google.ca/books?id=8g5QDwAAQBAJ&pg=PT195&lpg=PT195

I think it would be useful to cite this as an 'authoritative' reference (since the book is written by an RSpec maintainer), but I'm not sure what's the most appropriate way. Should it link to Google Books? Or Safari Books Online (which requires paid access)? Or should it just mention the book by its title?

@andyw8 andyw8 changed the title How to reference citations? How to reference sources? Apr 27, 2019
@andyw8 andyw8 changed the title How to reference sources? How to cite sources? Apr 27, 2019
@pirj
Copy link
Member

pirj commented Apr 27, 2019

Do you think that adding references to the commit description is sufficient, like e.g. here or here?

Unfortunately, the link to Google Books shows to me:

You have either reached a page that is unavailable for viewing or reached your viewing limit for this book.

However, when sections are being rearranged it's getting harder to get to those references.

Thanks for bringing this up, according to a comment, a number of suggestions in the open issues are influenced by a book you mention and an AmA post on Reddit. It would be nice not to lose track of this.

@andyw8
Copy link
Contributor Author

andyw8 commented Apr 27, 2019

I think it's useful to include reference with the commit/PR, but casual readers of the guide probably aren't going to refer back to those. It would be good to provide a way to better understand the reason and context for a particular piece of advice.

Linking to Google Books certainly isn't ideal. Perhaps it should remain neutral and only mention the ISBN, e.g.

Myron Marston, Ian Dees. Effective Testing with RSpec 3. Pragmatic Bookshelf, 2017. ISBN 9781680501988.

@bbatsov
Copy link
Contributor

bbatsov commented Apr 28, 2019

I agree that this is probably the best approach. Probably the references can just be simple footnotes so they won't distract the reader too much from the content.

@pirj
Copy link
Member

pirj commented May 29, 2019

This is going to be covered in #98.

@pirj pirj closed this as completed May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants