Recent rails commit benchmarks are not shown or are not running

[jerryliu55]

It seems like the latest rails commit benchmark is from Oct 3, 2016

[tgxworld]

The Rails commits are broken at the moment. I'll need to spend some time looking into them.

[bmarkons]

Following error occurs on bundle install --without test doc job

Gem::InstallError: ruby_dep requires Ruby version >= 2.2.5, ~> 2.2.
An error occurred while installing ruby_dep (1.5.0), and Bundler cannot continue.
Make sure that `gem install ruby_dep -v '1.5.0'` succeeds before bundling.

I guess solution would be to bump ruby version or modify version of listen gem since that's the one which depends on ruby_dep. Change listen gem version to 3.0.8 would fix the issue.

[bmarkons]

This change broke it on Oct 3, 2016 (as @jerryliu55 noticed) rails/rails@ddddedc

[bmarkons]

I bumped ruby version to 2.4.1 and updated rails_trunk Dockerfile accordingly. Some of benchmarks (postgres) are running properly but some are failing (mysql and actioncable). Logs can be seen on server.

Previous runs have been invalidated for recovered benchmarks because of ruby version change.

These specific benchmark errors need to be fixed.

[bmarkons]

This error is raised on ActiveRecord::Schema.define with mysql2:

/rails/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb:83:in `block in exec_stmt_and_free': NoMethodError: undefined method `free' for #<Mysql2::Result:0x007f687469cb78>: SELECT  `ar_internal_metadata`.* FROM `ar_internal_metadata` WHERE `ar_internal_metadata`.`key` = ? LIMIT ? (ActiveRecord::StatementInvalid)
        from /rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:580:in `block (2 levels) in log'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/monitor.rb:214:in `mon_synchronize'
        from /rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:579:in `block in log'
        from /rails/activesupport/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
        from /rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:571:in `log'
        from /rails/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb:59:in `exec_stmt_and_free'
        from /rails/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb:31:in `exec_query'
        from /rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:405:in `select_prepared'
        from /rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:40:in `select_all'
        from /rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:97:in `select_all'
        from /rails/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb:10:in `select_all'
        from /rails/activerecord/lib/active_record/querying.rb:39:in `find_by_sql'
        from /rails/activerecord/lib/active_record/relation.rb:660:in `exec_queries'
        from /rails/activerecord/lib/active_record/relation.rb:547:in `load'
        from /rails/activerecord/lib/active_record/relation.rb:256:in `records'
        from /rails/activerecord/lib/active_record/relation/finder_methods.rb:515:in `find_take'
        from /rails/activerecord/lib/active_record/relation/finder_methods.rb:100:in `take'
        from /rails/activerecord/lib/active_record/relation/finder_methods.rb:78:in `find_by'
        from /rails/activerecord/lib/active_record/relation.rb:234:in `find_or_initialize_by'
        from /rails/activerecord/lib/active_record/querying.rb:6:in `find_or_initialize_by'
        from /rails/activerecord/lib/active_record/internal_metadata.rb:18:in `[]='
        from /rails/activerecord/lib/active_record/schema.rb:56:in `define'
        from /rails/activerecord/lib/active_record/schema.rb:44:in `define'
        from /ruby-bench-suite/rails/benchmarks/bm_activerecord_validations_valid.rb:8:in `<main>'

This error is raised in scaffold benchmarks:

/rails/activesupport/lib/active_support/railtie.rb:35:in `rescue in block in <class:Railtie>': tzinfo-data is not present. Please add gem 'tzinfo-data' to your Gemfile and run bundle install (TZInfo::DataSourceNotFound)
        from /rails/activesupport/lib/active_support/railtie.rb:32:in `block in <class:Railtie>'
        from /rails/railties/lib/rails/initializable.rb:30:in `instance_exec'
        from /rails/railties/lib/rails/initializable.rb:30:in `run'
        from /rails/railties/lib/rails/initializable.rb:59:in `block in run_initializers'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:228:in `block in tsort_each'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:431:in `each_strongly_connected_component_from'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:349:in `block in each_strongly_connected_component'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:347:in `each'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:347:in `call'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:347:in `each_strongly_connected_component'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:226:in `tsort_each'
        from /root/.rbenv/versions/2.4.1/lib/ruby/2.4.0/tsort.rb:205:in `tsort_each'
        from /rails/railties/lib/rails/initializable.rb:58:in `run_initializers'
        from /rails/railties/lib/rails/application.rb:354:in `initialize!'
        from /rails/railties/lib/rails/railtie.rb:188:in `public_send'
        from /rails/railties/lib/rails/railtie.rb:188:in `method_missing'
        from /ruby-bench-suite/rails/benchmarks/bm_scaffold_update.rb:22:in `<main>'

And this error is raised in ActionCable benchmarks:

/ruby-bench-suite/rails/benchmarks/support/actioncable_helpers.rb:34:in `<top (required)>': undefined method `channel_paths=' for #<ActionCable::Server::Configuration:0x007f17623a12b0> (NoMethodError)
        from /ruby-bench-suite/rails/benchmarks/bm_actioncable_redis.rb:5:in `require_relative'
        from /ruby-bench-suite/rails/benchmarks/bm_actioncable_redis.rb:5:in `<main>'

[tgxworld]

Thanks for squashing all these 🐛

[bmarkons]

@tgxworld no problem 😉

Actually I didn't fix ActionCable. I fixed only mysql and scaffold benchmarks. Therefore I think this issue shouldn't be closed yet.

[bmarkons]

I've opened this more specific one #240

Closing this.