Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In new purchase, Category purchase values must be non-negative #5059

Open
2 tasks
cielf opened this issue Mar 2, 2025 · 2 comments · May be fixed by #5076
Open
2 tasks

In new purchase, Category purchase values must be non-negative #5059

cielf opened this issue Mar 2, 2025 · 2 comments · May be fixed by #5076
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 2, 2025

Summary

The category purchase values in new purchase / edit purchase should be constrained to be non-negative

Why?

Hygiene

Details

To see this, sign in as [email protected], then click "Purchases" and "New Purchase" in the left-hand menu.
Enter enough information to be able to save, including at least one negative number in the "purchase total for..." (still have the purchase total add up to the 4 category totals. Save.

It allows it! And shouldn't.

Put in checks so that none of the 'Purchase Total for..." fields can be negative.

Criteria for completion

  • behaviour as described above
  • tests to confirm behaviour as described above.
@cielf cielf added Good First Issue Suitable for users that are newer or less experienced SCALE2025 labels Mar 2, 2025
@jahuang415
Copy link

I can work on this issue.

@cielf
Copy link
Collaborator Author

cielf commented Mar 6, 2025

Thank you!

@jahuang415 jahuang415 linked a pull request Mar 6, 2025 that will close this issue
@cielf cielf removed the SCALE2025 label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants