-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to disable "Searching for emojis [...] is disabled" in address/search bar #139
Comments
Yeah, I would also have liked that. Unfortunately, the keyword that triggers the search needs to be statically defined. See: In our case, it is awesome-emoji-picker/src/manifest.json Line 26 in 26295d9
I also doubt Mozilla will change this, as dynamically changing the keyword could be abused to intercept (all) search queries So unfortunately, I have to say this issue is blocked, and I cannot really do anything here. Alternative solutions
|
@rugk In my case I could report this as a bug to Firefox, since I already entered a keyword (for a search engine). Though since they introduced search keyword being displayed differently than bookmark and add-on keywords, there is a difference in behavior. I'll need to make more tests before reporting. Also I have I don't mind hacking my own Firefox for my own usage, I have experience on (and the CPU/memory for) building Firefox. |
Yeah, I would agree that this is a Firefox bug, as users should not be able to use multiple keywords at once. Please do report it to them if you can.
See bug 1375453 for allowing the user to change the keyword. There are actually a lot of known issues with this feature, including that it does not work in private windows (bug 1779400) and it can only show a fixed number of suggestions (bug 1375252). |
Did you find the time to do this, @Exagone313? I totally agree, multiple keywords is not really useful/should not be possible. |
I didn't, but thanks for reminding me. 😅 |
I just created it: https://bugzilla.mozilla.org/show_bug.cgi?id=1796788 |
https://bugzilla.mozilla.org/show_bug.cgi?id=1815819 was fixed. This doesn't solve our issue completely, but the suggestion doesn't come anymore when the search is prefixed with |
Personally, I think the issue is now fixed in Firefox 130.
@hockdudu What do you think still need to be fixed? |
Okay https://hg.mozilla.org/mozilla-central/rev/e0b29efee642 reads like you can now at least not do enter two keywords at once. More could be done like allowing users to change they keyword. You could then change it to anything else to not let it interfere with whatever you type in the omnibox. |
I think this needs a separate issue. I'm closing the present one, but feel free to re-open it if you think something else is missing. |
Background
When I try to search for keywords starting by
emoji
and press enter, it redirects me to this addon preferences and I loose my search keywords. My current workaround is to never put emoji as a first keyword, which is not desired (since the first keyword usually has a greater weight in search engines).Proposed solution
Do not ask to enable this option when it is disabled.
Alternatives
Additional context
Integration is disabled:
The text was updated successfully, but these errors were encountered: