Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about gated deconv #37

Open
r06922019 opened this issue Jun 17, 2019 · 2 comments
Open

Question about gated deconv #37

r06922019 opened this issue Jun 17, 2019 · 2 comments

Comments

@r06922019
Copy link

Hi,

Thanks for your great work.
In your code,
https://github.com/run-youngjoo/SC-FEGAN/blob/master/ops.py#L50
this line states g = tf.nn.sigmoid(deconv)
However, IMHO the sigmoid should be applied to g itself to construct the gate
It should be g = tf.nn.sigmoid(g) right?
Did I misunderstand anything?

Thanks for your great work again!

@r06922019
Copy link
Author

Also, according to this line,
https://github.com/run-youngjoo/SC-FEGAN/blob/master/ops.py#L46
g = tf.nn.conv2d_transpose(input_, w, output_shape=output_shape, strides=[1, d_h, d_w, 1])
it seems that the gate g shares the same w used in deconv
Can you provide some thoughts on this?
Thanks again

@abtExp
Copy link

abtExp commented Sep 23, 2019

You're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants