Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify usage of GHA workflows from rusefi/rusefi repository #10

Open
kifir23917 opened this issue Jun 11, 2024 · 2 comments
Open

Unify usage of GHA workflows from rusefi/rusefi repository #10

kifir23917 opened this issue Jun 11, 2024 · 2 comments

Comments

@kifir23917
Copy link
Member

kifir23917 commented Jun 11, 2024

Currently Create Board Firmware GHA workflow reuses workflow from ext/rusefi submodule, while Update rusEFI Reference GHA workflow reuses workflow directly from rusefi/rusefi repository.
This potentially can cause inconsistency in versions of GHA workflows in use (for example we can unintentially use workflows from different branches).
Do we need to consider unification for ways of reusing GHA workflows from rusefi/rusefi repository?

@rusefillc
Copy link
Contributor

Definitely but zero priority until we figure out which approach is better when and why.

@chuckwagoncomputing
Copy link
Member

Create Board Firmware uses the custom action from the submodule because of this:
rusefi/rusefi#6114

The value of unification seems small to me.
Using a workflow/custom action from the submodule comes with downsides, listed in rusefi/rusefi#6162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants