Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[process proposal] peer review #379

Closed
rusefillc opened this issue Jan 13, 2023 · 2 comments
Closed

[process proposal] peer review #379

rusefillc opened this issue Jan 13, 2023 · 2 comments
Assignees

Comments

@rusefillc
Copy link
Contributor

@mi-hol please do not self-merge PRs right away, please allow someone else on the team to review and merge

#378 is an example of the approach which I believe we should adjust

@mi-hol
Copy link
Contributor

mi-hol commented Jan 13, 2023

@rusefillc the existing "[Proposal] make "master" a protected branch to enforce update via PRs only " #268 is from my view the solution to establish a defined workflow.
This new workflow would include peer review and will work independent of contributor's process knowledge.

At this stage the desired workflow seems not documented, please correct me in case I got this wrong.

To activate the setting "make "master" a protected branch "
could you please grant @chuckwagoncomputing "admin" role for rusefi/rusefi_documentation via settings/ Access ?
GitHub documentation for this topic is here

image

@rusefillc
Copy link
Contributor Author

https://github.com/rusefi/rusefi_documentation master branch is now protected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants