-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-lang repos that do not declare licenses #25664
Comments
|
@edunham CC0 seems suitable for the crates.io-index, if anything. |
Maybe I missed something, but this repo (rust-lang/rust) is also missing a license file. |
Not sure how I missed that. not enough coffee yet. |
I would like to take this issue up again. What is the status? Specifically on [licenses and copyright claims repeated in source code files](e.g. [ Arguments
Issues, my positions on them B. Who supports my position that a copyright claim is redundant, and that dating the copyright is even more redundant (certainly as the project keeps record using a VCS), and should be removed everywhere as a maintenance burden? @brson: What has led to the situation that multiple licenses are applicable to the |
The copyright year only matters 95 years after the date of first publication (treating this as a work of corporate authorship). So this repo begins to enter the US public domain in 2098 under current law. Best practice is to maintain copyright notice in a single file and let VCS sweat the details. |
@sanmai-NL the issues you are raising seem to be different from this issue, which is about ensuring that individual rust-lang repos declare a license (and on that basis I think we can close this issue - most of the remaining undeclared repos are not worth the effort). So you might consider opening another issue if you think the Rust source copyright is not handled properly. That said, the exact handling of the license declarations in this repo has been debated repeatedly over the years and I suspect there isn't much enthusiasm for re-litigating any aspect of it. The current scheme is as recommended by Mozilla legal long ago. It is true though that if we were to do it over with the benefit of hindsight I suspect we would push harder not to have the notice at the top of each file, nor to mention the copyright year. Here is an old discussion on the copyright year. We decided that mentioning the copyright year is useless, and that they should not be updated. The primary Rust codebase is Apache licensed because we want a permissive license with a patent non-aggression clause; it is MIT licensed because the GPLv2 is not compatible with the Apache license. Other licenses apply because Rust includes source from other projects such as LLVM. None of this can be changed with any reasonable amount of effort. |
@brson You wrote in that thread that the copyright notice at the top is not important legally, or so you had been advised (I assume by a legal professional). So I take it that removing them would be all right. I understand few will have appetite to consult legal professionals again though, if that's really what's needed. Irrelevant or not, the top copyright notice, especially with years with typos etc., and if long, is a bit of a nuisance I think so I suggest you just get rid of it. I wonder whether not declaring a license, even for small repos, is legally wise. Not just from a perspective of guarding against copyright infringement but also to foster re-use. |
Back to the topic of this issue, I agree that it's almost ready to be closed. Actions that other contributors can help us with to wrap up the loose ends are:
|
There's a thread open on irlo about the RFCs repo https://internals.rust-lang.org/t/relicense-the-rfcs-repo-under-the-cc-by-4-0-license/3870/3 |
So the thread on IRLO went silent, and I don't think the RFCs repo ever got any form of license, among others. @brson If we still care about this (and we do, I think), we should probably have core team discuss and decide on a license for the RFCs repo and then move towards adding that. |
Opened an RFC with a proposal to settle the licensing situation of rust-lang/rfcs: rust-lang/rfcs#2044 |
The RFC got merged and got a tracking issue #43461 . |
By looking at the checkbox list, can we say that this issue is now complete? Perhaps can be closed? thanks |
@apiraino since that comment, the github organization had new repos added to it. I went over the non-fork repos in the rust-lang organization and found the following repos without a top-level LICENSE file:
Plus a bunch of workgroup/team repos:
So this issue should very much not be closed, but thanks for pinging this issue because it motivated this mini-survey of mine. |
thanks @est31 for the important update :) |
What about applying tooling that checks for such things as licensing and SPDX headers, etc.? Checking for top level licenses is rote work and does not cover every concern. |
Even without a licensing tool for CI, you could query the GitHub API. |
@sanmai-NL yeah it would be nice to have some kind of automatted checking of this, and maybe every time there is a new repo being added, it would file a report to a dedicated github issue (or something like that). |
It came up today that kate-config does not have a license file. I filed a PR to fix that, but there are others.
-[ ] gedit-config - dual-licensedrepo abandoned- [ ] rust-wiki-backup - decommissioned partially because it was not properly licensedrepo archived- [ ] nano-config - Only contains copyright notice, not license Has both licensesrepo archived-[ ] zsh-config - dittorepo archivedUpdate:
docker-rust
repository under MIT/Apache-2.0 dual license docker-rust#207 - Adding License Statement (MIT and Apache) docker-rust#74[ ] docker-rust-nightly(the repository has been archived, the licensing is now being done in docker-rust)surveys
repository under the MIT/Apache-2.0 license surveys#267rustc-perf
repository under the MIT license rustc-perf#1933[ ] https://github.com/rust-lang/project-rfc-2229(archived)- [ ] https://github.com/rust-lang/rustc-timing(archived)The text was updated successfully, but these errors were encountered: