Enable IP_BOUND_IF on illumos and Solaris
#561
Conversation
The `IP_BOUND_IF` socket option, which is wrapped by the
`Socket::bind_device_by_index_{v4,v6}` and
`Socket::device_index_{v4,v6}` is available on SunOS-like systems, such
as illumos and Solaris, as well as macOS-like systems. However, these
APIs are currently cfg-flagged to only be available on macOS-like
systems.
This commit changes the cfg attributes to also enable these APIs on
illumos and Solaris.
Fixes rust-lang#560
hawkw
force-pushed
the
eliza/bind_if_on_illumos
branch
from
2928673 to
51e9773
Compare
|
Ugh, it looks like |
| // TODO: remove this once https://github.com/rust-lang/libc/pull/4287 merges | ||
| #[cfg(all(feature = "all", any(target_os = "illumos", target_os = "solaris")))] | ||
| const IP_BOUND_IF: libc::c_int = 0x41; |
There was a problem hiding this comment.
This is a bit of a bummer; I have an upstream PR rust-lang/libc#4287 to add these constants in libc, but wanted to test the change without that. I don't have a strong opinion on whether it's important to wait to pick these up from libc or if it's okay to just merge with a local definition and use them from libc in the future, but I imagine the maintainers will have an opinion on this.
There was a problem hiding this comment.
The libc pr is already merged, so let's wait for a release. I really don't want to maintain constants :)
There was a problem hiding this comment.
Yeah, I'm happy to wait --- this was just intended to allow testing the change temporarily. Once there's a new libc release, I'll pick it up and update this.
The
IP_BOUND_IFsocket option, which is wrapped by theSocket::bind_device_by_index_{v4,v6}andSocket::device_index_{v4,v6}is available on SunOS-like systems, suchas illumos and Solaris, as well as macOS-like systems. However, these
APIs are currently cfg-flagged to only be available on macOS-like
systems.
This commit changes the cfg attributes to also enable these APIs on
illumos and Solaris.
Fixes #560