Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Suggestions #3

Open
Moreless91 opened this issue Aug 11, 2022 · 6 comments
Open

Some Suggestions #3

Moreless91 opened this issue Aug 11, 2022 · 6 comments

Comments

@Moreless91
Copy link

Moreless91 commented Aug 11, 2022

I was able to get this working in Chrome, but not FireFox.

A setup guide would be nice, so I could build this on my machine.

A way to grade correctly scored and missed notes would be nice.

You can try using a dictionary with an answer key like this:

{
"note_coor": [
0, # 0 equals Measure 1
1, # 1 means Treb and 0 means Bass
6, # note position in measure: start at 0. See bar example below.
],
"midi": 48, # Midi Note to integer: Link
"offset": 1.8556701030927836, # seconds with decimal as ms. This is the position of the note in the song
"duration": 0.30927835051546415, # Duration of the note
"tieEnd": false, # Tied note
"clef": "F4" # This is based on if Treb/Bass or Clef Number 1 vs. 2. In XML: clef number='2' sign F and line 4
}

Bar 1 example notes:

Treb: 1 2 5 6
Clef: 0 1 2 4 5 6
Not sure how to format this in a comment. The "3" is blank because there's a pause, but it's implied it's there. There's just nothing to press on the keyboard so no need for a dictionary entry.

Picture of measure: Link

Every note would have it's own entry in the dictionary. Each key press on the keyboard would determine if the note was played correctly or incorrectly based off timing and appropriate key press.

@rvilarl
Copy link
Owner

rvilarl commented Aug 13, 2022

Thanks for the sugestions, I wil document how to build this, however, I do not get what you propose with the second suggestion. Could you provide more feedback?

@Moreless91
Copy link
Author

I'm saying that it should be possible to create an answer key to determine correctly played notes. The dictionary is a "map" for how to determine where a note is located on the music notation. When you input MIDI keys via key presses, the software would look at the dictionary to determine if what was just played is an incorrect or correct note. The dictionary probably needs some adjusting.

If this could be created and you were able to make the cursor flow fluidly across the screen, you could have you're own Playground Session software or software like Piano Marvel. Which is what i'm trying to find or build myself.

@rvilarl
Copy link
Owner

rvilarl commented Sep 23, 2022

@Moreless91 using start you already get feedback if the note was played correctly or not. It will only advance if you did it correctly. The program will also leave a 💩 if you did it incorrectly once. Do you suggest to color the notes like piano marvel?

@rvilarl
Copy link
Owner

rvilarl commented Sep 23, 2022

Build instructions added :)

@Moreless91
Copy link
Author

@rvilarl

Do you suggest to color the notes like piano marvel?

Yes, that would be "cleaner."

Is there a way to make the green bar line up with the grey bar here: https://imgur.com/a/HwzbLBk

The green bar seems to be one note or beat ahead while the grey bar is on the note being played. The green bar being ahead doesn't make sense. It should line up with the grey note.

Is it possible to make the bar fluidly move across the music score rather than "hop" from beat to beat. Here's an example of a bar moving fluidly across the music score: https://trinket.io/music

And thank you for the build notes!

@rvilarl
Copy link
Owner

rvilarl commented Sep 24, 2022

Is there a way to make the green bar line up with the grey bar here: https://imgur.com/a/HwzbLBk

The green bar seems to be one note or beat ahead while the grey bar is on the note being played. The green bar being ahead doesn't make sense. It should line up with the grey note.

@Moreless91 The grey bar moves with the tempo indicating which note/chord should be played (the one to the right of the cursor). The green cursor indicates which note/chord was already played. They are useful when training (start buttom) normally I go much slower than the tempo and the grey cursor goes much quicker than the green one which indicates where I am.

Is it possible to make the bar fluidly move across the music score rather than "hop" from beat to beat. Here's an example of a bar moving fluidly across the music score: https://trinket.io/music

@sschmidTU I believe that this is currently not possible in OSMD, is it? or, is it plan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants