Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename binary releases to ruby-bin-... #20

Open
havenwood opened this issue Jan 8, 2014 · 8 comments
Open

Rename binary releases to ruby-bin-... #20

havenwood opened this issue Jan 8, 2014 · 8 comments

Comments

@havenwood
Copy link
Member

Adding bin to Ruby binary releases avoids confusion between binary and source releases. So ruby-2.1.0.tar.bz2 binary would become ruby-bin-2.1.0.tar.bz2.

@mpapis
Copy link
Member

mpapis commented Jan 9, 2014

good point, we had to rename the binaries to bin-* when downloading into rvm/archives to avoid the same problem, would it be an issue if I would name then bin-ruby-* instead of ruby-bin-*?

@havenwood
Copy link
Member Author

It does avoids binary/source confusion either way. I do think ruby-bin-* would be a bit better than bin-ruby-* though. Having source and binary Rubies always start with ruby-* seems like a good thing. Also JRuby is currently doing jruby-bin-* and adopting that convention might be a nice thing for the community going forward.

Not quite as easy as prepending bin- to the name but I think ruby-bin-* may be worth doing? Perhaps something like RUBY_BIN_ARCHIVE="${RUBY_ARCHIVE%%-*}-bin-${RUBY_ARCHIVE##*-}" for a bash substitution solution. Or is bin-ruby-* a preferred naming convention to adopt for other reasons?

@mpapis
Copy link
Member

mpapis commented Jan 9, 2014

bin-* mostly to limit scope of the changes and to keep compatibility with existing code as rvm 1.x is feature frozen, I'm not sold on the jruby conversion as it requires injecting the -bin- into the name compared to the simple prefixing the name - less code = less errors ...

@ghost
Copy link

ghost commented Jan 9, 2014

the filename bin-ruby looks unusual and strange to me. i would prefer ruby-bin, but then again I'm not writing any code to download these tarballs.

@postmodern
Copy link

@robgleeson I concur. I've only seen project-foo-1.2.3 or project-1.2.3-foo. ruby-2.0.0-bin looks OK.

@richo
Copy link
Member

richo commented Jan 9, 2014

+1 for ${ruby_version}-bin

@headius
Copy link

headius commented Jan 9, 2014

JRuby has used jruby-bin-version and jruby-src-version for many years, so that's my vote.

@grk
Copy link
Contributor

grk commented Jan 10, 2014

ruby-bin-version seems most logical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants