Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review auto-setting of t_max in glideid.py/_process_tag_data() #5

Open
ryanjdillon opened this issue Oct 9, 2017 · 0 comments
Open

Comments

@ryanjdillon
Copy link
Owner

ryanjdillon commented Oct 9, 2017

In section 3.2.1 Determine stroke_frq fluking rate and cut-off frequency the value t_max is not updated automatically with a calculated value. The default value of 2.5 seconds entered in cfg_glide.yml is used for the rolling average.

This could be updated to function similar to Lucia's script, but my doing this appeared to create erroneous values for t_max, so further diagnosing should be done.

        # Store user input cutoff and stroke frequencies
        cfg['cutoff_frq']   = cutoff_frq
        cfg['stroke_frq']   = stroke_frq
        cfg['stroke_ratio'] = stroke_ratio

        # TODO seting to hardcode t-max, not calculate from stroke_frq
        ## Calculate maximum duration of glides from stroke frequency
        #cfg['t_max']  = 1 /cfg['stroke_frq']  # seconds
ryanjdillon added a commit that referenced this issue Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant