Source text doesn't equal text after encoding and decoding

[mikevolgo]

Hi,

I've found a situation when after encoding and decoding text is not equal to source text. Example

text = 'ABCDEFGHIJKLMNOPQRSTUVWXYZÄÖÑܧ¿abcdefghijklmnopqrstuvwxyzäöñüà'
print(codec.decode(codec.encode(text)) == text)
False
print(codec.decode(codec.encode(text)))
ABCDEFGHIJKLMNOPQRSTUVWXYZÄÖÑܧ¿abcdefghijklmnopqrstuvwxyzäöñüà@

we can see that after encoding/decoding an extra symbol "@" is added.

[sacha-senchuk]

Hi,

Thanks for the report.

Do you already have an idea why this might happen?

[sacha-senchuk]

It seems like you have been using the GSM encoding.

There is a caveat that requires padding in certain situations:

https://github.com/qotto/smspdudecoder/blob/master/smspdudecoder/codecs.py#L87

In your case, you should consider using the following code:

from smspdudecoder.codecs import GSM

text = 'ABCDEFGHIJKLMNOPQRSTUVWXYZÄÖÑܧ¿abcdefghijklmnopqrstuvwxyzäöñüà'

assert GSM.decode(GSM.encode(text, with_padding=True), strip_padding=True) == text

I probably need to create a new version of the package where padding is enabled by default, to be in-line with the GSM specifications:

[sacha-senchuk]

Hello, a quick update here.

This will be taken care of in the upcoming v3 of the library.