Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to AppKit from WalletConnect #3701

Closed
katspaugh opened this issue May 14, 2024 · 2 comments
Closed

Migrate to AppKit from WalletConnect #3701

katspaugh opened this issue May 14, 2024 · 2 comments
Labels
tech debt

Comments

@katspaugh
Copy link
Member

katspaugh commented May 14, 2024 •
edited
Loading

What is the feature about

Based on the research from #2953, we took the decision to migrate from web3-onboard to AppKit.

The list of requirements

  • Remove onboard and add AppKit
  • Refactor all the code that references onboard
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} May 14, 2024
@katspaugh katspaugh moved this from New issues to Todo in Safe{Wallet} May 14, 2024
@usame-algan usame-algan moved this from Todo to In Progress in Safe{Wallet} May 16, 2024
@usame-algan usame-algan self-assigned this May 16, 2024
@usame-algan usame-algan mentioned this issue May 16, 2024
Closed
3 tasks
@mayone mayone mentioned this issue May 17, 2024
Open
@usame-algan usame-algan moved this from In Progress to Todo in Safe{Wallet} Jun 17, 2024
@usame-algan usame-algan removed their assignment Jun 17, 2024
@usame-algan
Copy link
Member

Moved this back for now. The PoC works nicely but is missing Ledger and Trezor support since those modules don't exist yet.

@katspaugh katspaugh moved this from Todo to New issues in Safe{Wallet} Jun 17, 2024
@katspaugh katspaugh changed the title Migrate to Web3Modal Migrate to AppKit from WalletConnect Aug 8, 2024
@katspaugh katspaugh removed the blocked label Nov 27, 2024
@katspaugh
Copy link
Member Author

Currently not feasible due to the lack of Ledger support.

@katspaugh katspaugh closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2025
@github-project-automation github-project-automation bot moved this from New issues to Done in Safe{Wallet} Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
Safe{Wallet}
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

POC: Add web3modal safe-global/safe-wallet-monorepo
2 participants
@katspaugh @usame-algan