Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWAPs do not work with older Safe versions #4402

Open
johannesmoormann opened this issue Oct 21, 2024 · 1 comment
Open

TWAPs do not work with older Safe versions #4402

johannesmoormann opened this issue Oct 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@johannesmoormann
Copy link
Member

Bug description

Using TWAPs with Safe versions equal to or older than 1.1.1 does not work likely due to not injecting the msg.sender when invoking the fallback handler, which is something that the Extensible Fallback Handler expects. It does not seem solvable and we should prevent users with older Safe version from interacting with TWAPS and asking them to upgrade.

Steps to reproduce

  1. Go to Swaps and try using it with a Safe version older than 1.3.0

Expected result

I cannot use the TWAP feature with a non-compatible Safe version.

Obtained result

I run into errors when executing the transaction.

Screenshots

@johannesmoormann johannesmoormann added the bug Something isn't working label Oct 21, 2024
@liliya-soroka
Copy link
Member

existing 15.11.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@liliya-soroka @johannesmoormann and others