Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated Multichain balances are wrong for networks without default tokenlists #4479

Open
schmanu opened this issue Nov 5, 2024 · 1 comment · May be fixed by #4495
Open

Aggregated Multichain balances are wrong for networks without default tokenlists #4479

schmanu opened this issue Nov 5, 2024 · 1 comment · May be fixed by #4495
Labels
bug Something isn't working

Comments

@schmanu
Copy link
Member

schmanu commented Nov 5, 2024

Bug description

When requesting the Safe overviews to display fiat balances in the network selector and sidebar we always pass trusted=true regardless of the default tokenlist setting and feature flag.

This leads to always 0$ balance for e.g. Base Safes.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Open a Base safe with non zero fiat balance.
  2. Observe that the sidebar and network selector always shows 0$ while the assets list and dashboard shows the actual value.

Expected result

The same fiat value as shown on the dashboard.

Obtained result

Always a 0$ value

Screenshots

Screenshot 2024-11-05 at 14 48 30

@schmanu schmanu added the bug Something isn't working label Nov 5, 2024
@schmanu schmanu linked a pull request Nov 6, 2024 that will close this issue
3 tasks
@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 15, 2024

Verified, fixed in the connected PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants