Skip to content
This repository has been archived by the owner on Dec 16, 2024. It is now read-only.

Support abstract socket addresses in Pipe.bind/Pipe.connect #248

Closed
geertj opened this issue Jun 7, 2017 · 2 comments
Closed

Support abstract socket addresses in Pipe.bind/Pipe.connect #248

geertj opened this issue Jun 7, 2017 · 2 comments

Comments

@geertj
Copy link
Contributor

geertj commented Jun 7, 2017

As per:

joyent/libuv#1486 (comment)

would you accept a patch to add abstract socket support to Pipe.bind() and Pipe.listen()?

This would be Linux only, and fail on non-Linux (probably with UV_EINVAL?)

On Linux this would create an AF_UNIX socket, call connect() or bind(), then do do a uv_pipe_open() on the FD. I investigated this as some point in the past, and I remember that both operations never block on Linux (these are local sockets), so I'd not do anything complicated for handling EINTR. Instead I would make the FD non-blocking only after it is successfully bound/connected, and I would depend on Linux not to block (or worst-case block for a very small amount of time).

@geertj
Copy link
Contributor Author

geertj commented Jun 9, 2017

PR #250

@saghul
Copy link
Owner

saghul commented Jul 5, 2017

PR landed!

@saghul saghul closed this as completed Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants