Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining efforts #15

Open
zvictor opened this issue Aug 22, 2022 · 4 comments
Open

Combining efforts #15

zvictor opened this issue Aug 22, 2022 · 4 comments

Comments

@zvictor
Copy link

zvictor commented Aug 22, 2022

Great work and beautiful aesthetic improvements, @sakerhetspolisen !

I am just wondering if you have considered creating a PR and merging your work with @harshzalavadiya's.

On one hand your project looks has a much better look, but his is better maintained. Can't we combine the efforts here? Everybody could benefit a lot! 😊

@harshzalavadiya what are your thoughts on a possible merge?

@harshzalavadiya
Copy link

harshzalavadiya commented Aug 22, 2022

Thanks @zvictor for pointing it out
this is amazing @sakerhetspolisen

I'll be happy to add him as official maintainer on the repo if @sakerhetspolisen is okay with the same

also if he doesn't mind I can create PR in my repo cherry picking changes from here (of course attributing @sakerhetspolisen as author)

@sakerhetspolisen
Copy link
Owner

@zvictor thanks for reaching out and @harshzalavadiya thanks for your good work on react-web-share. I'd be super happy to join forces on this one, you can gladly create a PR as you stated! 👍

@harshzalavadiya
Copy link

@sakerhetspolisen awesome, I've added write access for https://github.com/hc-oss/react-web-share repository, feel free to create PR, we can release v3.x when your PR merges

@sakerhetspolisen
Copy link
Owner

@sakerhetspolisen awesome, I've added write access for https://github.com/hc-oss/react-web-share repository, feel free to create PR, we can release v3.x when your PR merges

Hi again @harshzalavadiya I'm so sorry for not replying earlier. Are you still interested and willing to send me another invitation? I've completely forgot to accept the invitation and it seems like the old one has expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants