Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose Multiplatform support #9

Open
saket opened this issue May 15, 2023 · 14 comments
Open

Compose Multiplatform support #9

saket opened this issue May 15, 2023 · 14 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@saket
Copy link
Owner

saket commented May 15, 2023

Migrating Modifier.zoomable() to multiplatform should be easy is done, but SubSamplingImage() will need to be decoupled from Android's BitmapRegionDecoder for lazy loading of bitmap tiles.

Target platforms

JVM

Apple

For loading of images, @colinrtwhite plans to migrate Coil to multiplatform in v3.

@saket
Copy link
Owner Author

saket commented Jun 2, 2023

Thanks to @DSteve595, Modifier.zoomable() will be available as a multiplatform library in the next release 🎉

@Phaestion
Copy link

Hi @saket! From what I can gather multiplatform in this context means Android and Desktop right? I can only see the Android and Desktop versions of the zoomable library published.
I do see you have a reference to Apple in the original description of the issue, is this part still outstanding?

@saket
Copy link
Owner Author

saket commented Oct 2, 2023

I do see you have a reference to Apple in the original description of the issue, is this part still outstanding?

Yep! Wanna help out by sending a PR? 😊

@saket
Copy link
Owner Author

saket commented Feb 6, 2024

For folks following this issue, Coil has started publishing experimental builds with multiplatform support. I'm going to wait a bit for its APIs and maven coordinates to settle before integrating it with telephoto.

@LOOHP
Copy link

LOOHP commented Feb 25, 2024

Hi, does it mean telephoto will support wasm target soon as well?

@saket
Copy link
Owner Author

saket commented Feb 26, 2024

@LOOHP I don't have any plans for the web yet. Are you actually displaying large images on the web that require subsampling?

@LOOHP
Copy link

LOOHP commented Feb 26, 2024

I'm working on displaying a large railway system map with each station being clickable to perform some action. So it needs to stay HD when it is zoomed in.
If telephoto supports wasm as well, it would be fantastic as I will be able to use it for Android, IOS, JVM & Web all in the same Compose Multiplatform code.

@panpf

This comment was marked as spam.

@saket

This comment was marked as off-topic.

@panpf

This comment was marked as spam.

@Vichy97
Copy link

Vichy97 commented Sep 13, 2024

If the zoomable modifier already is KMP compatible, could a KMP compatible release be made for just the modifier? I am unable to use this in a KMP project as-is, but I only need the modifier

@saket
Copy link
Owner Author

saket commented Sep 13, 2024

Modifier.zoomable() is already available for the JVM and Android. What other platforms are you targeting? We can add the rest here, if you want to send a PR:

jvm("desktop")
if (pluginManager.hasPlugin("com.android.library")) {
androidTarget {

@Vichy97
Copy link

Vichy97 commented Sep 13, 2024

@saket I am looking to target Android and iOS primarily

@Vichy97
Copy link

Vichy97 commented Sep 13, 2024

I've created a PR #102 but I'm not sure if this makes sense. Is there a way to make iOS targets for just the Modifier library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants