Add start mission button #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tepel-chen
force-pushed
the
feature/start-mission
branch
from
093dcc7 to
7504132
Compare
samfundev
requested changes
Mar 5, 2023
tepel-chen
force-pushed
the
feature/start-mission
branch
from
b8a555e to
f9c60d3
Compare
samfundev
approved these changes
Mar 20, 2023
|
Much improved, thank you. Though I think we could push even more of that ts code you added to the mission page into the component. And it will have to be thoroughly tested by me and Rex for bugs. |
samfundev
requested changes
Mar 25, 2023
| demilErrorMessage = `A room that can support more bombs is required. Current rooms only support up to ${bombCountError.MaximumSupportedBombsCount} bombs, and the mission has ${bombCountError.MissionBombsCount} bombs.`; | ||
| demilHelpState = 'Error'; | ||
| } else { | ||
| toast.success(`Started mission ${missionResult.MissionID}`); |
There was a problem hiding this comment.
We shouldn't use the mission ID but the mission name.
|
|
||
| <Dialog bind:dialog> | ||
| {#if typeof demilHelpState !== 'undefined'} | ||
| <div class="block"> |
There was a problem hiding this comment.
Can you remove this block element? It makes it look the dialog has a weird thick gray border around it.
Luminoscity
requested changes
Mar 25, 2023
Comment on lines
+84
to
+104
| let demilClient = new DeMiL.DeMiLClient(8095); | ||
| async function startMission() { | ||
| demilHelpState = undefined; | ||
| try { | ||
| const missionResult = await demilClient.startMissionByName(mission.name, steamID); | ||
| demilVersion = !missionResult.IsVersionInRange ? missionResult.Version ?? '<2.1.0' : undefined; | ||
| if (missionResult.hasOwnProperty('MissingModules')) { | ||
| missingModules = (missionResult as DeMiL.StartMissionMissingModulesResult).MissingModules.map(mod => | ||
| getModule(mod, modules) | ||
| ); | ||
| demilHelpState = 'MissingModules'; | ||
| } else if (missionResult.hasOwnProperty('MissionModulesCount')) { | ||
| let moduleCountError = missionResult as DeMiL.StartMissionTooManyModulesResult; | ||
| demilErrorMessage = `Failed to start mission. A bomb that can support more modules is required. Current bombs only support up to ${moduleCountError.MaximumSupportedModulesCount} modules, and the mission has ${moduleCountError.MissionModulesCount} modules.`; | ||
| demilHelpState = 'Error'; | ||
| } else if (missionResult.hasOwnProperty('MissionBombsCount')) { | ||
| let bombCountError = missionResult as DeMiL.StartMissionTooManyBombsResult; | ||
| demilErrorMessage = `A room that can support more bombs is required. Current rooms only support up to ${bombCountError.MaximumSupportedBombsCount} bombs, and the mission has ${bombCountError.MissionBombsCount} bombs.`; | ||
| demilHelpState = 'Error'; | ||
| } else { | ||
| toast.success(`Started mission ${missionResult.MissionID}`); |
There was a problem hiding this comment.
I think literally all of this from line 84 to 117 can be in the component instead of in the mission page code and you just pass it the mission object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #91