/disguise [entity] as player does not directly fully support arbitrary GameProfiles (player UUIDs)

[James103]

As of commit 1274902 (tested on 660c818), the /disguise command does not support using an arbitrary GameProfile (player UUID/skin/cape/etc) for arbitrary entities with different UUIDs. Currently, the only way to get a specific player disguise for example is to spawn the entity with the UUID of the player whose skin you want and then run the /disguise [UUID of target player/entity] as player on that entity, or run a command like the following, replacing the UUID with that of whatever player you want the disguise to be:

summon minecraft:villager ~ ~1 ~ {
	CustomName: '""',
	UUID: [I;569325948,980831927,-1441289827,1069963490],
	DisguiseLib: {
		DisguiseType: "minecraft:player",
		DisguiseAlive: 1b
	}
}

/help output for disguise command for reference (notice no extra arguments to insert the target player UUID)

/disguise <entity> as minecraft:player
/disguise <entity> as player
/disguise <entity> as <disguise> [<nbt>]

This is likely caused by the following commented out lines. Do you why these lines are commented out?

MobDisguises/common/src/main/java/org/samo_lego/mobdisguises/command/DisguiseCommand.java

Lines 47 to 57 in 660c818

	.then(literal("minecraft:player")
	/*.then(argument("playername", word())
	.executes(DisguiseCommand::disguiseAsPlayer)
	)*/
	.executes(DisguiseCommand::disguiseAsPlayer)
	)
	.then(literal("player")
	/*.then(argument("playername", word())
	.executes(DisguiseCommand::disguiseAsPlayer)
	)*/
	.executes(DisguiseCommand::disguiseAsPlayer)

[samolego]

Those have been left out in the first release, as they weren't ready yet. It's a planned feature but I haven't had time to fully implement it yet.

[James103]

Maybe as an alternative to using player names, would it be possible to also allow the use of real player UUIDs for the playername argument? That would fit in line with already existing behavior for commands that accept both names and UUIDs, where /kill <your UUID> has the same effect as /kill <your username>.

[samolego]

Maybe as an alternative to using player names, would it be possible to also allow the use of real player UUIDs for the playername argument? That would fit in line with already existing behavior for commands that accept both names and UUIDs, where /kill <your UUID> has the same effect as /kill <your username>.

I'd rather stick with playernames, as they are more "user-friendly". I believe that messing with entity UUIDs can lead to some trouble as well.

[James103]

If this sort of command is implemented, would you be able to make it so multiple entities can be disguised as players corresponding to the same player name (GameProfile), or would each player-disguised entity need to have its own GameProfile?

If multiple entities can be disguised as the same GameProfile, that would simply things a lot because you don't have to find multiple players with the skin you want to be able to use that skin on multiple player disguises at once.

[samolego]

Yes, skin is saved in different property in the GameProfile.

[James103]

Would the skin of the GameProfile associated with the player-disguised entity be cached somewhere as well (meaning even if the underlying player changes his/her skin, the player-disguised entity's skin does not change unless manually updated)

[samolego]

It would be cached until re-login