Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack::Test is an unspecified runtime dependency #76

Open
wmene opened this issue Mar 5, 2014 · 1 comment
Open

Rack::Test is an unspecified runtime dependency #76

wmene opened this issue Mar 5, 2014 · 1 comment

Comments

@wmene
Copy link

wmene commented Mar 5, 2014

The Rubydora::Datastream#behaves_like_io? method references the Rack::Test::UploadedFile class

def behaves_like_io?(obj)
      obj.is_a?(IO) || (defined?(Rack) && obj.is_a?(Rack::Test::UploadedFile))
end

https://github.com/projecthydra/rubydora/blob/master/lib/rubydora/datastream.rb#L405

However, the gemspec does not declare rack-test as a runtime dependency. I was using rubydora/active-fedora in a Sinatra webservice when I kept getting the error

NameError: uninitialized constant Rack::Test

because this dependency was missing

@jcoyne
Copy link
Contributor

jcoyne commented Mar 5, 2014

I don't think we want to require rack-testas a dependency, but we should check to see if Rack::Test is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants