Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a work visibility in sirenia generates Failed save on # undefined method `split' for nil:NilClass message in sirenia #6874

Closed
rjkati opened this issue Aug 6, 2024 · 4 comments · May be fixed by #6884

Comments

@rjkati
Copy link

rjkati commented Aug 6, 2024

Descriptive summary

In Hyrax 5.0.1 running Sirenia, when I attempt to update the visibility of a work, I receive a Failed save on # undefined method split' for nil:NilClass` message and the visibility does not update.

Steps to reproduce the behavior in User Interface (UI)

  1. Run a local build of Sirenia using Docker
  2. Log in and navigate to Dashboard -> Works
  3. Click on the title of a work that you've already deposited (or deposit a new one if you don't have any works)
  4. Click Edit
  5. Select a different visibility setting (I went from Public to Institution) and click Save Changes
  6. Observe message Failed save on # undefined method split' for nil:NilClass`
  7. Go back to Dashboard -> Works and observe that visibility has not updated

undefinedmethod

Actual behavior (include screenshots if available)

Attempting to change the visibility of a work generates Failed save on # undefined method split' for nil:NilClass` message and does not update the visibility.

Acceptance Criteria/Expected Behavior

Attempting to change the visibility of a work should update the visibility accordingly

Rationale (for feature request only)

Provide the rationale or user story that describes "why" this issue should be addressed. Especially if this is a new feature or significant change to the existing implementation.

Related work

#6864

@rjkati
Copy link
Author

rjkati commented Aug 7, 2024

This issue does not occur on dev.nurax or pg.nurax

@bwatson78
Copy link
Contributor

I will refocus on making this change on the Valkyrie level, unless @dlpierce is already working on this.

@bwatson78
Copy link
Contributor

PR in Valkyrie (samvera/valkyrie#960, already merged) will fix this issue.

@rjkati rjkati moved this to In Progress in Hyrax-Fedora 6 Aug 28, 2024
@rjkati
Copy link
Author

rjkati commented Sep 9, 2024

This works while running the valkyrie-fedora-fix branch locally. I can change the visibility of a work without getting an error message

@rjkati rjkati closed this as completed Sep 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyrax-Fedora 6 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants