Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile/merge optools and reportables #526

Open
coreyostrove opened this issue Jan 17, 2025 · 1 comment
Open

Reconcile/merge optools and reportables #526

coreyostrove opened this issue Jan 17, 2025 · 1 comment
Assignees
Milestone

Comments

@coreyostrove
Copy link
Contributor

At present we have a lot of code duplication between function in optools and functions in reportables, particularly with regards to distance metrics where we have a lot of near exact duplication. We also have some functionality that is in reportables and not in optools (e.g. instrument fidelity and instrument diamond distance), which makes this functionality harder to find. We should consider finding a better way of managing this overlapping code and reducing the amount of duplication/parity mismatch present.

@coreyostrove coreyostrove self-assigned this Jan 17, 2025
@coreyostrove coreyostrove added this to the 0.9.15+ milestone Jan 17, 2025
@sserita
Copy link
Contributor

sserita commented Jan 17, 2025

Thanks for making this issue, I was just thinking about this recently as well... My gut feeling is that I'd like most things to be in tools and the report code can use the tools to generate the tables as needed. But open to alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants