You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At present we have a lot of code duplication between function in optools and functions in reportables, particularly with regards to distance metrics where we have a lot of near exact duplication. We also have some functionality that is in reportables and not in optools (e.g. instrument fidelity and instrument diamond distance), which makes this functionality harder to find. We should consider finding a better way of managing this overlapping code and reducing the amount of duplication/parity mismatch present.
The text was updated successfully, but these errors were encountered:
Thanks for making this issue, I was just thinking about this recently as well... My gut feeling is that I'd like most things to be in tools and the report code can use the tools to generate the tables as needed. But open to alternatives.
At present we have a lot of code duplication between function in optools and functions in reportables, particularly with regards to distance metrics where we have a lot of near exact duplication. We also have some functionality that is in reportables and not in optools (e.g. instrument fidelity and instrument diamond distance), which makes this functionality harder to find. We should consider finding a better way of managing this overlapping code and reducing the amount of duplication/parity mismatch present.
The text was updated successfully, but these errors were encountered: