Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: releases is opt-out; remove explicit opt in for test-studio #8765

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Feb 25, 2025

Description

Removing explicit opt-in for test studio workspaces

What to review

Testing

Notes for release

N/A

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:12am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:12am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 25, 2025 0:12am
test-next-studio ⬜️ Ignored (Inspect) Feb 25, 2025 0:12am
page-building-studio ⬜️ Skipped (Inspect) Feb 25, 2025 0:12am

@jordanl17 jordanl17 marked this pull request as ready for review February 25, 2025 12:12
@jordanl17 jordanl17 requested a review from a team as a code owner February 25, 2025 12:12
@jordanl17 jordanl17 requested review from bjoerge and removed request for a team February 25, 2025 12:12
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.41% 54330 / 128079
🔵 Statements 42.41% 54330 / 128079
🔵 Functions 47.25% 2726 / 5769
🔵 Branches 79.43% 10257 / 12912
File CoverageNo changed files found.
Generated in workflow #31087 for commit 9c4ddb1 by the Vitest Coverage Report Action

Copy link
Contributor

Component Testing Report Updated Feb 25, 2025 12:23 PM (UTC)

❌ Failed Tests (3) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 24s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 22s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 56s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 17s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 17s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 52s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 3m 21s 19 0 2
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 55s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 25 Feb 2025 12:25:15 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 19.0 efps (53ms) 20.6 efps (49ms) -4ms (-7.6%)
article (body) 54.8 efps (18ms) 56.2 efps (18ms) -0ms (-2.5%)
article (string inside object) 23.3 efps (43ms) 23.5 efps (43ms) -1ms (-1.2%)
article (string inside array) 20.8 efps (48ms) 21.3 efps (47ms) -1ms (-2.1%)
recipe (name) 52.6 efps (19ms) 47.6 efps (21ms) +2ms (+10.5%)
recipe (description) 58.8 efps (17ms) 55.6 efps (18ms) +1ms (+5.9%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 20.0 efps (50ms) -1ms (-2.0%)
synthetic (string inside object) 20.0 efps (50ms) 20.6 efps (49ms) -2ms (-3.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 53ms 83ms 102ms 457ms 1306ms 12.5s
article (body) 18ms 24ms 63ms 321ms 515ms 7.4s
article (string inside object) 43ms 45ms 49ms 208ms 376ms 7.5s
article (string inside array) 48ms 51ms 65ms 242ms 673ms 8.0s
recipe (name) 19ms 21ms 26ms 41ms 0ms 7.3s
recipe (description) 17ms 19ms 20ms 30ms 0ms 4.5s
recipe (instructions) 6ms 7ms 11ms 24ms 0ms 3.2s
synthetic (title) 51ms 54ms 63ms 231ms 1065ms 13.6s
synthetic (string inside object) 50ms 53ms 71ms 397ms 1359ms 9.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 49ms 71ms 83ms 502ms 1040ms 11.6s
article (body) 18ms 21ms 32ms 159ms 189ms 6.1s
article (string inside object) 43ms 45ms 51ms 157ms 392ms 7.7s
article (string inside array) 47ms 51ms 54ms 183ms 491ms 7.7s
recipe (name) 21ms 22ms 25ms 44ms 0ms 8.0s
recipe (description) 18ms 19ms 21ms 24ms 0ms 4.6s
recipe (instructions) 6ms 8ms 9ms 34ms 0ms 3.3s
synthetic (title) 50ms 52ms 54ms 205ms 712ms 13.3s
synthetic (string inside object) 49ms 52ms 71ms 605ms 1330ms 8.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant