-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): make PTE active by default #8778
base: next
Are you sure you want to change the base?
Conversation
There's been some feedback internally and externally that it would be nice if the Portable Text Input was active by default. So I think we should try it. Therefore, the default value of the `PortableTextInput.initialActive` prop has been flipped from `false` to `true`.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Editor Performance ReportUpdated Wed, 26 Feb 2025 15:28:06 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me, thanks
Description
There's been some feedback internally and externally that it would be nice if the Portable Text Input was active by default. So I think we should try it.
Therefore, the default value of the
PortableTextInput.initialActive
prop has been flipped fromfalse
totrue
.What to review
Does it work as expected? Is an input with
initialActive={false}
correctly made inactive on mount?Testing
Some existing component tests have been adjusted to match the new behaviour.
Notes for release
The Portable Text Input is now active by default