Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection should disconnect if it doesn't get a keepalive in a while #15

Open
sanity opened this issue May 27, 2012 · 3 comments
Open
Assignees

Comments

@sanity
Copy link
Owner

sanity commented May 27, 2012

Connections should keep track of the last time they received a KEEPALIVE message from the other guy (handled on line 193 of UdpRemoteConnection) and call disconnect() if a keepalive hasn't been received in a certain amount of time.

Keepalives are sent every 7 seconds currently (TrConstants.UDP_KEEP_ALIVE_DURATION), so 30 seconds might be a good timeout.

@ghost ghost assigned nomel7 May 27, 2012
@nomel7
Copy link
Collaborator

nomel7 commented Mar 9, 2013

A disconnecting node which knows it's disconnecting because of TopologyMaintenance should also call a disconnect() session. This isn't happening as can be seen in LongTests.main().

@sanity
Copy link
Owner Author

sanity commented Jun 3, 2013

@nomel7 Can you elaborate on what you mean here?

@nomel7
Copy link
Collaborator

nomel7 commented Jun 15, 2013

If a node reaches its max peers, and is "changing" some of its peers because of a maintenance session, it should notify the peers that it's removing those peers so that they can in turn remove the "changer". Currently the node which is disconnected from doesn't know that it has been removed by the "changer" and may still try start sessions with the "changer".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants