Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopologyMaintenanceTest contains an integration test, not a unit test #46

Open
sanity opened this issue Oct 18, 2013 · 1 comment
Open

TopologyMaintenanceTest contains an integration test, not a unit test #46

sanity opened this issue Oct 18, 2013 · 1 comment

Comments

@sanity
Copy link
Owner

sanity commented Oct 18, 2013

Similar problem to #45. Leaving it enabled for now since it's all we've got, but it needs to be replaced with proper specific unit tests.

TopologyMaintenanceTest should test the code in the TopologyMaintenance class only, and an absolutely minimal amount of code outside this class.
@jacksingleton
Copy link
Collaborator

Started working on this, still wip, see 7d42fa7

jacksingleton added a commit that referenced this issue Oct 27, 2013
@jacksingleton
#46 - Finished adding unit tests for TopologyMaintenanceSessionImpl
d963f54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanity @jacksingleton