Genesis/MD over-logging when forcing cart size

[PsychoFox11]

OSCR firmware version

14.5 (latest master)

OSCR hardware version

HW5 Rev5

Attach OSCR_LOG.txt file here

OSCR HW5 V14.5

[+] Mega Drive/Genesis

[+] Game Cartridge

Cart Info

Name: SAMPLEPROGRAM
bramCheck: E100
Size: 8 MBit
ChkS: D7ED
Sram: 256 KBit

Press Button...

[+] Force ROM size

ROM Size: 1 Mbit

ROM Size: 2 Mbit

ROM Size: 4 Mbit

ROM Size: 8 Mbit

ROM Size: 12 Mbit

ROM Size: 16 Mbit

ROM Size: 20 Mbit

ROM Size: 24 Mbit

ROM Size: 32 Mbit

ROM Size: 40 Mbit

ROM Size: 1 Mbit

ROM Size: 40 Mbit

ROM Size: 32 Mbit

ROM Size: 24 Mbit

ROM Size: 20 Mbit

ROM Size: 16 Mbit

ROM Size: 12 Mbit

ROM Size: 8 Mbit

ROM Size: 4 Mbit

ROM Size: 2 Mbit

ROM Size: 1 Mbit

ROM Size: 40 Mbit

ROM Size: 1 Mbit

ROM Size: 2 Mbit

ROM Size: 4 Mbit

ROM Size: 8 Mbit

ROM Size: 12 Mbit

ROM Size: 16 Mbit

ROM Size: 12 Mbit

ROM Size: 8 Mbit

ROM Size: 4 Mbit

ROM Size: 2 Mbit

ROM Size: 1 Mbit

ROM Size: 40 Mbit

ROM Size: 32 Mbit

ROM Size: 32 Mbit
Press Button...

[+] Read ROM

Saving to MD/ROM/SAMPLEPROGRAM/1494/...
[*******************]
Internal checksum...Error
8C6E

CRC32... D609AE4F -> Not found

System used

Sega Mega Drive/Genesis

Describe the issue.

Not the biggest deal in the world, but both the game and OSCR log record each time you scroll by a size, as you can see in my example. I turned the knob several times to illustrate it. This typically wouldn't be that big, but nonetheless seems like something that should be fixed.

There was recently an issue where it was doing this for other menus that was fixed by a change in the main ino file, so I'm not sure how this should be tackled specifically, as it only happens under Sega (of course I haven't checked every sub-menu of every console, I did verify things like mapper selection on NES weren't logging). I can come up with code that works but I don't think it's likely the best approach, so I'm reporting it instead!

[sanni]

Try changing this function in md.ino:

void printRomSize_MD(int index) {
  display_Clear();
  print_Msg(FS(FSTRING_ROM_SIZE));
  print_Msg(pgm_read_byte(&(MDSize[index])));
  println_Msg(F(" Mbit"));
}

like so:

void printRomSize_MD(int index) {
#ifdef ENABLE_GLOBAL_LOG
  // Disable log to prevent unnecessary logging
  dont_log = true;
#endif

  display_Clear();
  print_Msg(FS(FSTRING_ROM_SIZE));
  print_Msg(pgm_read_byte(&(MDSize[index])));
  println_Msg(F(" Mbit"));

#ifdef ENABLE_GLOBAL_LOG
  // Enable log again
  dont_log = false;
#endif
}