Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapterkind to be specified in external inventory_config #188

Open
viennaa opened this issue Dec 14, 2021 · 0 comments
Open

Adapterkind to be specified in external inventory_config #188

viennaa opened this issue Dec 14, 2021 · 0 comments

Comments

@viennaa
Copy link
Collaborator

viennaa commented Dec 14, 2021

With the new inventory_config we have seen, that implementing a new resourcekind leads to adding all the respective functions in our code. Let's take vcops as an example.

The following places need to be adapted:
Config
InventoryBuilder 1
InventoryBuilder 2permanent query
InventoryBuilder 3
Vrops.py

That scheme goes on for every new adapter, currently for our two additional adapters, sddc and vcops.
We need to make that generic and have the adapterkind specified in inventory_config. Instead of the specific implementation we need to run through generic functions which would take the content of the config file instead to specify the needed adapterkind.

At least these two adapters should be reworked that way.

TBD:
When we have that as a first step, we should consider reworking vcenter_objects and nsxt_objects too. The hard lock in for nsx-t might not fit every use case others may have, just because we are using it. Now that we have the possibility to externally configure this kind of stuff, we should outsource it too. However, the implementation of the latter is different and needs some more love before that's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant