New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Serialize and Deserialize implementations #10

Open

Chadehoc opened this issue Dec 11, 2024 · 0 comments

Chadehoc commented Dec 11, 2024

Some structures are intended to travel between server and client, and should implement Serialize and Deserialize.

Currently:

Handshake is Serialize (server side ok), missing Deserialize for the client side;
HandshakeProof implements nothing, missing Serialize and Deserialize;
HandshakeProofVerifier (server side) and UserCredentials (client side) are Serialize, which is strange as they should never be exchanged. Also UserDetails is Serialize, which seems useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment